Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for catchcn ensemble run #645

Merged
merged 8 commits into from
Oct 18, 2022
Merged

support for catchcn ensemble run #645

merged 8 commits into from
Oct 18, 2022

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Sep 20, 2022 •
edited by gmao-rreichle
Loading

Correct the child name for different ensemble members of catchcn.
Required to support ensemble simulations with CatchCN in GEOSldas needed by @gmao-jkolassa.

Dependencies:

@weiyuan-jiang weiyuan-jiang added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This fixes a bug labels Sep 20, 2022
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner September 20, 2022 19:45
@gmao-rreichle gmao-rreichle added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Sep 21, 2022
@weiyuan-jiang weiyuan-jiang added Draft and removed 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Sep 21, 2022
@weiyuan-jiang
Copy link
Contributor Author

@gmao-rreichle It is not ready yet. Some variables need to be bubbled up to the Land grid comp so the GEOSens grid comp can see them.

@gmao-rreichle gmao-rreichle marked this pull request as draft September 21, 2022 17:07
@gmao-rreichle gmao-rreichle added the Contingent - DNA These changes are contingent on other PRs (DNA=do not approve) label Sep 21, 2022
@gmao-rreichle
Copy link
Contributor

I successfully 0-diff tested the branch at the current commit ba5672b
@gmao-jkolassa successfully exercised the new functionality after the initial commit dca3508
Since @weiyuan-jiang just reported that additional changes will be needed, testing will need to be repeated later.

@weiyuan-jiang
Copy link
Contributor Author

This PR depends on the PR on MAPL GEOS-ESM/MAPL#1683

@weiyuan-jiang weiyuan-jiang mentioned this pull request Sep 22, 2022
Merged
@gmao-rreichle gmao-rreichle removed Contingent - DNA These changes are contingent on other PRs (DNA=do not approve) Draft labels Oct 12, 2022
@gmao-rreichle gmao-rreichle marked this pull request as ready for review October 12, 2022 14:19
@sdrabenh sdrabenh merged commit 775925a into develop Oct 18, 2022
@sdrabenh sdrabenh deleted the feature/wjiang/catchcn_ensemble branch October 18, 2022 14:36
gmao-rreichle added a commit to GEOS-ESM/GEOSldas that referenced this pull request Oct 18, 2022
@gmao-rreichle
Support for CatchCN ensemble simulations (#584)
9a7ec25 
Added CatchCN-specific export variables to EnsGridComp. 
See also GCM GC PR GEOS-ESM/GEOSgcm_GridComp#645
@mathomp4 mathomp4 mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biljanaorescanin biljanaorescanin biljanaorescanin approved these changes

@sdrabenh sdrabenh sdrabenh approved these changes

Assignees

@weiyuan-jiang weiyuan-jiang

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiyuan-jiang @gmao-rreichle @sdrabenh @biljanaorescanin