Skip to content

add all exports from a direct child #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Sep 22, 2022

In GEOSldas, the exports in Catchment or CatchmentCN need to be bubbled up to Land grid comp and to GEOSens grid comp for average. It is inconvenient to add and repeat all exports.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner September 22, 2022 13:44
@weiyuan-jiang weiyuan-jiang added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 22, 2022
@mathomp4 mathomp4 mentioned this pull request Sep 26, 2022
7 tasks
@mathomp4
Copy link
Member

I tested this (along with #1655) with the GCM and it seems zero-diff and good to go.

@mathomp4 mathomp4 requested a review from tclune September 29, 2022 14:48
@mathomp4 mathomp4 merged commit 4d1ec52 into develop Oct 3, 2022
@mathomp4 mathomp4 deleted the feature/wjiang/add_all_exports branch October 3, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants