-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable CatchmentCNCLM45 (LSM_CHOICE=3) #900
Conversation
… (GEOS_SurfaceGridComp.F90, SurfParams.F90, GEOS_CatchCNGridComp.F90)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR only comments out a few if blocks for CatchmentCNCLM45. I'd call it trivially 0-diff. CI build and runs work. @sdrabenh, please let us know if you need more formal testing.
Instead of commenting it, why don't you just remove this choice? |
A more thorough code cleanup will be done when we replace CatchCNCLM4.5 with CatchCNCLM5.1. This is a quick safety to make sure nobody can bypass the corresponding changes in setup. |
@gmao-rreichle in that case, we'll need an issue that goes with this PR. The issue I suggest would have: |
@sanAkel : Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me.
Fine with me too |
This PR disables the use of CatchmentCNCLM45 (LSM_CHOICE=3) and supersedes #898.
This particular model version has lots of science issues, and NCAR discourages the use of CLM45, from which the carbon and nitrogen cycle components of CatchmentCNCLM45 are borrowed.
The PR removes the LAND_PARAMS=CN_CLM45 option from the surface resource file and removes the LSM_CHOICE=3 option in select case/if blocks to make sure the code does not run with this model version. A more thorough source code cleanup will be needed at a later time.
Related PRs:
GEOS-ESM/GEOSldas#707
This PR is zero-diff.
See also planned cleanup of source code #907
cc: @gmao-rreichle , @biljanaorescanin