Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed nbinsDU and nbinsSS arguments from subroutine NIheterogenousChem #175

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Removed nbinsDU and nbinsSS arguments from subroutine NIheterogenousChem #175

merged 2 commits into from
Aug 23, 2022

Conversation

weiyuan-jiang
Copy link
Contributor

This PR addresses issue #171

@weiyuan-jiang weiyuan-jiang added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Aug 22, 2022
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner August 22, 2022 14:00
@weiyuan-jiang weiyuan-jiang changed the base branch from main to develop August 22, 2022 14:01
@amdasilva amdasilva self-assigned this Aug 23, 2022
amdasilva
amdasilva approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although code no longer gives NaNs, it still may not work correctly. It has no effect for current GOCART-2G configuration at GMAO, so going with it for now. A better fix needs to be implemented.

@amdasilva
Copy link
Collaborator

Will need better fix later on.

@amdasilva amdasilva merged commit e1c9686 into develop Aug 23, 2022
@amdasilva amdasilva deleted the feature/wjiang/clean_up_NIheterogenousChem branch August 23, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amdasilva amdasilva amdasilva approved these changes

Assignees

@amdasilva amdasilva

Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiyuan-jiang @amdasilva