Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed nbinsDU and nbinsSS arguments from subroutine NIheterogenousChem #175

Merged
merged 2 commits into from
Aug 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Removed nbinsDU and nbinsSS arguments from subroutine NIheterogenousChem
- Updated ExtData2G yaml files to handle AMIP magic date
- Fix bug in getAerosolSum
- more hard-coded name changes for Issue #93
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,7 @@ subroutine Run2 (GC, import, export, clock, RC)
call NIheterogenousChem (NIHT, self%xhno3, MAPL_UNDEF, MAPL_AVOGAD, MAPL_AIRMW, &
MAPL_PI, MAPL_RUNIV/1000., airdens, t, rh2, delp, DU, &
SS, self%rmedDU*1.e-6, self%rmedSS*1.e-6, &
self%fnumDU, self%fnumSS, 5, 5, self%km, self%klid, &
self%fnumDU, self%fnumSS, self%km, self%klid, &
self%cdt, MAPL_GRAV, fMassHNO3, fMassNO3, NO3an1, NO3an2, &
NO3an3, HNO3CONC, HNO3SMASS, HNO3CMASS, __RC__)

Expand Down
11 changes: 7 additions & 4 deletions Process_Library/GOCART2G_Process.F90
Original file line number Diff line number Diff line change
Expand Up @@ -4732,8 +4732,8 @@ end subroutine phobicTophilic
!
! !INTERFACE:
subroutine NIheterogenousChem (NI_phet, xhno3, UNDEF, AVOGAD, AIRMW, PI, RUNIV, rhoa, tmpu, relhum, delp, &
DU, SS, rmedDU, rmedSS, fnumDU, fnumSS, nbinsDU, nbinsSS, &
km, klid, cdt, grav, fMassHNO3, fMassNO3, nNO3an1, nNO3an2, &
DU, SS, rmedDU, rmedSS, fnumDU, fnumSS, &
km, klid, cdt, grav, fMassHNO3, fMassNO3, nNO3an1, nNO3an2, &
nNO3an3, HNO3_conc, HNO3_sfcmass, HNO3_colmass, rc)


Expand All @@ -4758,8 +4758,6 @@ subroutine NIheterogenousChem (NI_phet, xhno3, UNDEF, AVOGAD, AIRMW, PI, RUNIV,
real, dimension(:) ,intent(in) :: rmedSS ! sea salt aerosol radius [um]
real, dimension(:) ,intent(in) :: fnumDU ! number of dust particles per kg mass
real, dimension(:) ,intent(in) :: fnumSS ! number of sea salt particles per kg mass
integer, intent(in) :: nbinsDU ! number of dust bins
integer, intent(in) :: nbinsSS ! number of sea salt bins
integer, intent(in) :: km ! number of model levels
integer, intent(in) :: klid ! index for pressure lid
real, intent(in) :: cdt ! chemistry model timestep (sec)
Expand All @@ -4785,6 +4783,8 @@ subroutine NIheterogenousChem (NI_phet, xhno3, UNDEF, AVOGAD, AIRMW, PI, RUNIV,
real, dimension(:,:,:), allocatable :: deltahno3

integer :: i1, j1, i2, j2, n, i, j, k
integer :: nbinsDU ! number of dust bins
integer :: nbinsSS ! number of sea salt bins


!
Expand All @@ -4797,6 +4797,9 @@ subroutine NIheterogenousChem (NI_phet, xhno3, UNDEF, AVOGAD, AIRMW, PI, RUNIV,
!------------------------------------------------------------------------------------
! Begin..

nbinsDU = size(DU,4)
nbinsSS = size(SS,4)

! Heterogeneous chemistry
! -----------------------
! Heterogeneous chemistry wants to know about GOCART dust and sea
Expand Down