Skip to content

Commit

Permalink
Simplify error (#211)
Browse files Browse the repository at this point in the history
* Patch for #203

* Responding to comments on #206

* Update core.py

Add missing space to call to UF.get_box()

* Replace all get_box calls to have options.enlargeBox, change get_box to refer only to enlargeBox instead of options.enlargeBox

---------

Co-authored-by: AlvaroCubi <55387701+AlvaroCubi@users.noreply.github.com>
Co-authored-by: Grammer, Kyle <grammerkb@ornl.gov>
  • Loading branch information
3 people authored and psauvan committed Jun 17, 2024
1 parent e0aa4ad commit cb09470
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/geouned/GEOUNED/conversion/cell_definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ def no_overlapping_cell(metaList, surfaces, options):
t_def, simplify = t_def_and_simplify
if True in simplify:
logger.info(f"reduce cell {m.__id__}")
box = UF.get_box(m)
box = UF.get_box(m, options.enlargeBox)

# evaluate only diagonal elements of the Constraint Table (fastest) and remove surface not
# crossing in the solid boundBox
Expand Down
4 changes: 2 additions & 2 deletions src/geouned/GEOUNED/utils/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
from . import basic_functions_part2 as BF


def get_box(comp, options):
def get_box(comp, enlargeBox):
bb = FreeCAD.BoundBox(comp.BoundBox)
bb.enlarge(options.enlargeBox)
bb.enlarge(enlargeBox)
xMin, yMin, zMin = bb.XMin, bb.YMin, bb.ZMin
xLength, yLength, zLength = bb.XLength, bb.YLength, bb.ZLength

Expand Down

0 comments on commit cb09470

Please sign in to comment.