Simplify error #211
Merged
Simplify error #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev to main
Add missing space to call to UF.get_box()
…to refer only to enlargeBox instead of options.enlargeBox
|
These three line changes look good to me. |
|
I think this is ready to merge and should not require another attempt (famous last words). |
psauvan
approved these changes
Jun 7, 2024
psauvan
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Patch for #203 * Responding to comments on #206 * Update core.py Add missing space to call to UF.get_box() * Replace all get_box calls to have options.enlargeBox, change get_box to refer only to enlargeBox instead of options.enlargeBox --------- Co-authored-by: AlvaroCubi <55387701+AlvaroCubi@users.noreply.github.com> Co-authored-by: Grammer, Kyle <grammerkb@ornl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The get_box function in functions.py took the parameters comp and options, and used only options.enlargeBox. The previous fix in core.py for the call to this function passed self.options.enlargeBox. cut_box has been changed to take the parameters comp and enlargeBox.
An additional call to cut_box is in cell_definition.py that was missing the second parameter. The call here has been replaced with changed from only "m" to "m" and options.enlargeBox.
The result of the first issue is that simplify = "full" fails.
Fixes issue
Previous fix to #203 was not sufficient. This should be.
Checklist