-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails when anything other than "ORSRoutingFile" set for "routing_name" #424
Comments
@rabidllama It seems like the |
I believe it was introduced when the gpx output was added as it was some sort of required value in the response |
Here's what I did
Setting the routing_name property within the app.config and building ORS
Here's what I got
the build fails with on the unit test testCreateRouteFeatureType in SimpleFeatureTypeTest as it expects always to be named as ORSRoutingFile even when a value has been set in the app.config - it seems that the creation of the feature always accesses the app.config even for running unit tests
Here's what I was expecting
That ors should build when a value is entered in the app.config for routing_name. Also, the name of the property itself is a bit vague, and it seems that when applying the name to the feature, anything after a space is ignored.
Here's what I think could be improved
Either the unit tests should ensure that the app.config is not used for building the object, or the test should be removed as unit tests shouldn't be dependant on external items
The text was updated successfully, but these errors were encountered: