Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix-#424 build-fail #485

Merged
merged 1 commit into from
Apr 3, 2019
Merged

bugfix-#424 build-fail #485

merged 1 commit into from
Apr 3, 2019

Conversation

MichaelsJP
Copy link
Member

Pull Request Checklist

  • 1. I have rebased the latest version of the development branch into my feature branch and all conflicts have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the app.config file, I have added these to the app.config wiki page on github along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset (at least Germany) and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the importer etc.), I have generated longer distance routes for the affected profiles with different options (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end points generated from the current live ORS. If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage and why the change was needed.

Fixes #424 .

Information about the changes

  • Key functionality added: Ability to specify the gpx name tag in the config file
  • Reason for change: It wasn't working properly before and also crashed the build process when the variable wasn't set.

Examples and reasons for differences between live ORS routes and those generated from this pull request

Required changes to app.config (if applicable)

@MichaelsJP MichaelsJP added the bug 🐞 Erroneous behavior of the backend label Mar 29, 2019
@MichaelsJP MichaelsJP added this to the 5.1 milestone Mar 29, 2019
@MichaelsJP MichaelsJP self-assigned this Mar 29, 2019
@MichaelsJP MichaelsJP requested a review from rabidllama March 29, 2019 16:12
@nilsnolde
Copy link
Contributor

nilsnolde commented Apr 1, 2019

API test failing:
ResultTest.testGpxExport:137->testGpxConsistency:271 null expected:<[ORSRouting]> but was:<[openrouteservice directions]

Pls wait with a fix until the #486 is merged into development and rebase again.

@MichaelsJP MichaelsJP force-pushed the bugfix-#-#424/build-fail branch from 03c2548 to 0f35e52 Compare April 1, 2019 18:42
@MichaelsJP MichaelsJP force-pushed the bugfix-#-#424/build-fail branch from 0f35e52 to 81a9993 Compare April 1, 2019 18:45
@rabidllama rabidllama merged commit 0972806 into development Apr 3, 2019
@rabidllama rabidllama deleted the bugfix-#-#424/build-fail branch April 3, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Erroneous behavior of the backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants