Fixes for glvis-js

[justinlaughlin]

Some of the changes in v4.3 broke portions of aux_js.cpp because they aren't using the updated constructors, enums, etc. This PR makes updates so we can build glvis-js again.

[najlkin]

Btw, how is this compiled? And another one, how about adding support for quadrature functions? 🤔

[justinlaughlin]

Btw, how is this compiled? And another one, how about adding support for quadrature functions? 🤔

Basically, follow the build section in the README: https://github.com/GLVis/glvis-js

Although, in order to build I needed to make a change in mfem (PR) and also use an older emscripten version. I want to setup CI similar to mfem->pymfem so it will rebuild glvis-js on pushes to glvis master 😅

Quadrature support sounds good! Let's make it a separate PR though so this can get into master 😄

[najlkin]

Omg, that is complicated, ok I trust you it can be build 😉 . That CI sounds great. We may also wait for it and merge it here (like a dependent PR, keeping it open) 🚀 .
That quadrature support I was partially mentioning because it uses that coarse mesh, so there would be no need for the new/old constructors 🤔 . If you do not want it here, it is ok, we may add it temporarily. Just please add some comment to them like "used only for backward compatibility with glvis-js".

[justinlaughlin]

@najlkin Is it okay to always pass StreamState.mesh_quad e.g. like in

vs = vss = new VisualizationSceneSolution(*stream_state.mesh, stream_state.sol,
                                          stream_state.mesh_quad.get(), &stream_state.normals);

even if we aren't using quadrature visualization? If so then I can remove the new constructors.

[najlkin]

Yes, this is how it works in glvis.cpp now. Stream state does not set the coarse mesh unless it is that quadrature function OR it is 1D, which was the bug in the other PR 😅 .

[najlkin]

Btw, a funny thing is that I do not use that coarse mesh at all 😄 , it is only for indication that you want to visualize the coarse mesh lines or not, but it is conceptually cleaner to do it this way, because it is just an implementation detail that there is no dependency, but you could use it somehow in principle.

[justinlaughlin]

Okay, sounds good to me!

[najlkin]

Besides that, it seems to me that GLVis live should be able to load and visualize quadratures with this update automatically, since we are loading stream files directly 😮 .

[justinlaughlin]

Thanks for reviewing 😎