Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Js enum binding #313

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Js enum binding #313

merged 2 commits into from
Aug 29, 2024

Conversation

justinlaughlin
Copy link
Contributor

We made some changes in #310 to use StreamState::FieldType but the enum also needed to be bound in emscripten.

najlkin
najlkin approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@najlkin najlkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not like I could check anything much, but looks sensible 😉.

@justinlaughlin justinlaughlin merged commit 3cdb2d6 into master Aug 29, 2024
10 checks passed
@justinlaughlin
Copy link
Contributor Author

Not like I could check anything much, but looks sensible 😉.

Our lovely new CI will build glvis-js for you 😄. All you need to do is use the artifact and run examples/basic.html.

@justinlaughlin justinlaughlin deleted the js-enum-binding branch August 29, 2024 22:43
@tzanio
Copy link
Member

tzanio commented Aug 30, 2024

Not like I could check anything much, but looks sensible 😉.

Our lovely new CI will build glvis-js for you 😄. All you need to do is use the artifact and run examples/basic.html.

That's awesome work and really great improvement, @justinlaughlin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@najlkin najlkin najlkin approved these changes

@tzanio tzanio tzanio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinlaughlin @tzanio @najlkin