-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flip drawing of negative strand PAF features in linear synteny and dotplot views #2024
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2024 +/- ##
==========================================
- Coverage 60.85% 60.84% -0.01%
==========================================
Files 473 473
Lines 22552 22562 +10
Branches 5245 5248 +3
==========================================
+ Hits 13724 13728 +4
- Misses 8546 8552 +6
Partials 282 282
Continue to review full report at Codecov.
|
ab45f47
to
efa7e95
Compare
efa7e95
to
8c7b0e0
Compare
went ahead with merge...can review if needed it is maybe interesting to note that strand only exists on "one column" of a PAF file e.g. the query can be flipped or not, and there was no handling of strand at all in the current code, so this adds that |
It was seen in https://gist.github.com/cmdcolin/f9f0c1c61b7c840475c1815a7a607239 that there were a lot of "inversions" but these may be that we are not actually drawing reverse strand features right. This tries to fix that by flipping the start and end coordinates in the dotplot
We may need to make a similar confirmation for the linear synteny views