Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip drawing of negative strand PAF features in linear synteny and dotplot views #2024

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented May 28, 2021

It was seen in https://gist.github.com/cmdcolin/f9f0c1c61b7c840475c1815a7a607239 that there were a lot of "inversions" but these may be that we are not actually drawing reverse strand features right. This tries to fix that by flipping the start and end coordinates in the dotplot

We may need to make a similar confirmation for the linear synteny views

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 28, 2021
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #2024 (8c7b0e0) into main (6062089) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2024      +/-   ##
==========================================
- Coverage   60.85%   60.84%   -0.01%     
==========================================
  Files         473      473              
  Lines       22552    22562      +10     
  Branches     5245     5248       +3     
==========================================
+ Hits        13724    13728       +4     
- Misses       8546     8552       +6     
  Partials      282      282              
Impacted Files Coverage Δ
...tenyRenderer/components/LinearSyntenyRendering.tsx 1.56% <0.00%> (-0.08%) ⬇️
...otplot-view/src/DotplotRenderer/DotplotRenderer.ts 66.25% <100.00%> (+1.31%) ⬆️
plugins/dotplot-view/src/PAFAdapter/PAFAdapter.ts 92.85% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6062089...8c7b0e0. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

before:
localhost_3000__config=test_data%2Fmashmap%2Fconfig json session=local-j-foTATSt (1)

after:
localhost_3000__config=test_data%2Fmashmap%2Fconfig json session=local-j-foTATSt

@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 28, 2021
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 28, 2021
@cmdcolin
Copy link
Collaborator Author

This type of change may also be needed for the linearsyntenyrenderer, e.g. for a inverted large contig seen in the after, then we expect an inversion

e.g. open this region in linear synteny view
120044066-1d955100-bfdb-11eb-8899-0032319b76c0 (1)

before:
localhost_3000__config=test_data%2Fmashmap%2Fconfig json session=local-TcbpAWfP1 (5)

after:
localhost_3000__config=test_data%2Fmashmap%2Fconfig json session=local-TcbpAWfP1 (6)

we can also flip the top level for example

before:
localhost_3000__config=test_data%2Fmashmap%2Fconfig json session=local-TcbpAWfP1 (8)

after:
localhost_3000__config=test_data%2Fmashmap%2Fconfig json session=local-TcbpAWfP1 (7)

@cmdcolin cmdcolin force-pushed the fix_paf_dotplot_reverse branch from ab45f47 to efa7e95 Compare May 28, 2021 23:53
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 1, 2021
@cmdcolin cmdcolin marked this pull request as ready for review June 1, 2021 16:12
@cmdcolin cmdcolin force-pushed the fix_paf_dotplot_reverse branch from efa7e95 to 8c7b0e0 Compare June 1, 2021 16:13
@cmdcolin cmdcolin changed the title Flip drawing of negative strand PAF features in dotplot view Flip drawing of negative strand PAF features in linear synteny and dotplot views Jun 2, 2021
@cmdcolin cmdcolin merged commit b690d24 into main Jun 2, 2021
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 2, 2021

went ahead with merge...can review if needed

it is maybe interesting to note that strand only exists on "one column" of a PAF file e.g. the query can be flipped or not, and there was no handling of strand at all in the current code, so this adds that

@cmdcolin cmdcolin deleted the fix_paf_dotplot_reverse branch June 2, 2021 07:17
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jul 6, 2021

Screenshot from 2021-07-06 14-39-05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant