Reorient strands on read vs ref plots #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
removed
the
needs label triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix from #2024 caused a knock-on effect of the read-vs-ref displays to display inversions where none existed. Reason being was that the read vs ref code assumed it should provide the strand of the read, but even though the strand of a given BAM read might be given as -1, all the data is actually oriented in the forward direction (e.g. the SEQ field will be read left to right aka 5' to 3' even for negative strand features)
Example: Current main displays inversions on a "volvox SV" example which should not be inversions (it is just a deletion)