Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read vs ref not finding primary alignment on certain CRAM files #2952

Merged
merged 2 commits into from
May 16, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented May 15, 2022

Currently, there is a routine to get the primary read if you start with a supplementary read for linear ReadVsRef visualization. It requests reads overlapping a single base pair where the start of the primary read is. One issue though is there is likely an off-by-one error in specifically CRAM feature fetching where if I request reads overlapping ctgA:0-1, it does not return anything. Making it request ctgA:0-2 is a workaround, but fixing the off by one would be worthwhile

Also, fixes error handling on the read vs ref dialog (previously, the error wasn't displayed)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 15, 2022
@cmdcolin
Copy link
Collaborator Author

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 15, 2022
@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #2952 (e566b2f) into main (58a7a4d) will increase coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head e566b2f differs from pull request most recent head 1f83c59. Consider uploading reports for the commit 1f83c59 to get more accurate results

@@            Coverage Diff             @@
##             main    #2952      +/-   ##
==========================================
+ Coverage   60.67%   60.71%   +0.03%     
==========================================
  Files         601      601              
  Lines       27341    27341              
  Branches     6654     6655       +1     
==========================================
+ Hits        16590    16599       +9     
+ Misses      10441    10431      -10     
- Partials      310      311       +1     
Impacted Files Coverage Δ
plugins/linear-comparative-view/src/ReadVsRef.tsx 63.90% <33.33%> (-0.60%) ⬇️
...ments/src/SNPCoverageAdapter/SNPCoverageAdapter.ts 56.37% <100.00%> (ø)
...ckages/core/pluggableElementTypes/RpcMethodType.ts 83.33% <0.00%> (-2.09%) ⬇️
packages/core/util/layouts/GranularRectLayout.ts 87.28% <0.00%> (+0.42%) ⬆️
...FeatureRenderer/components/ProcessedTranscript.tsx 88.73% <0.00%> (+1.40%) ⬆️
packages/core/TextSearch/TextSearchManager.ts 91.89% <0.00%> (+2.70%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 84.84% <0.00%> (+3.03%) ⬆️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 95.91% <0.00%> (+4.08%) ⬆️
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 86.20% <0.00%> (+6.89%) ⬆️
...svg/src/SvgFeatureRenderer/components/Segments.tsx 92.85% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a7a4d...1f83c59. Read the comment docs.

@cmdcolin cmdcolin merged commit 476bbb3 into main May 16, 2022
@cmdcolin cmdcolin deleted the fix_read_vs_ref2 branch May 16, 2022 19:39
@cmdcolin cmdcolin changed the title Fix read vs ref on certain CRAM files Fix read vs ref not finding primary alignment on certain CRAM files May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant