Fix crash displaying modifications called on softclipped regions of reads #2964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a crash displaying modifications, example share link
https://jbrowse.org/code/jb2/v1.7.0/?config=test_data%2Fconfig_demo.json&session=share-Jfg7Adjvai&password=ZCjW1
This is probably due to displaying a modifications that was called on a soft clipped area of a read (e.g. a part of the read that did not properly map to the reference genome)
Instead of trying to display these (and currently, causing a crash) this PR proposes to filter them out