-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add about dialog with version number for embedded components #3162
Conversation
a4ff642
to
6d151e3
Compare
6d151e3
to
139ccfe
Compare
Codecov Report
@@ Coverage Diff @@
## main #3162 +/- ##
==========================================
- Coverage 58.72% 58.68% -0.04%
==========================================
Files 668 672 +4
Lines 29139 29161 +22
Branches 7088 7091 +3
==========================================
+ Hits 17111 17113 +2
- Misses 11650 11669 +19
- Partials 378 379 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
any thoughts on this? could potentially allow it to be user customizable too perhaps |
I changed the code a little so that it only runs the bundler (generating the UMD bundles) in the postversion step, so the right version gets bundled then (if it is bundled in the build step, the predecessor version will get bundled since version is made after build) |
a858a23
to
f51a006
Compare
* Output version * Add version * Use IconButton * Update snaps * Only bundle after postversion so that we get the proper version bundled in the app
This writes a version.js file to the embedded components "postversion" in the build cycle, and allows the component to access the version number while running
Clicking on the "Logo" in the top right of the viewcontainer then pops up a small about dialog