Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the UMD build of the react embedded components #3191

Merged
merged 6 commits into from
Sep 16, 2022

Conversation

cmdcolin
Copy link
Collaborator

the PR in #3162 did not quite work, as the version number was not updated. I should test this PR out maybe on a locally private npm publish to see if it works but this PR changes the logic a bit to use prepack instead of postversion, and commits the change

reference
https://github.com/semantic-release/semantic-release/blob/master/docs/support/FAQ.md#how-can-i-use-a-npm-build-script-that-requires-the-packagejsons-version-

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #3191 (6ef189b) into main (fa36931) will not change coverage.
The diff coverage is n/a.

❗ Current head 6ef189b differs from pull request most recent head 694d166. Consider uploading reports for the commit 694d166 to get more accurate results

@@           Coverage Diff           @@
##             main    #3191   +/-   ##
=======================================
  Coverage   59.48%   59.48%           
=======================================
  Files         671      671           
  Lines       28734    28734           
  Branches     6968     6968           
=======================================
  Hits        17092    17092           
  Misses      11320    11320           
  Partials      322      322           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

actually this only affected the storybook build. still need to properly git commit the version change in the postversion step, but it is accurately reported in e.g. our demos like https://jbrowse.org/demos/lgv/

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 15, 2022
@cmdcolin cmdcolin changed the title Fix the version number reported by embedded components during build Fix the version number reported by embedded components Sep 15, 2022
@cmdcolin cmdcolin force-pushed the put_version_in_src_embedded branch from 6adaab3 to 9e5a7f3 Compare September 15, 2022 20:31
@garrettjstevens
Copy link
Collaborator

It looks like bundle (which was introduced in #3162) in @jbrowse/react-linear-genome-view didn't get run, so the UMD files were not included in the last release (see unpkg for 2.1.3 vs. 2.1.2). Will this fix that issue as well?

@cmdcolin
Copy link
Collaborator Author

just saw that! checking into it now

bump version.js

bump version.js

bump version.js
@cmdcolin cmdcolin force-pushed the put_version_in_src_embedded branch from 5a9cefe to fbafc82 Compare September 16, 2022 16:45
@cmdcolin
Copy link
Collaborator Author

i think this should be fixed now. I can see on the release machine the umd bundles were never created but this branch should create them properly, and it changes postversion to prepack

@cmdcolin
Copy link
Collaborator Author

I could investigate why postversion doesn't work perhaps but i think we could go ahead and create a quick point release with this to restore UMD@latest

@cmdcolin cmdcolin marked this pull request as ready for review September 16, 2022 16:56
@cmdcolin cmdcolin merged commit fbbe8e3 into main Sep 16, 2022
@cmdcolin cmdcolin deleted the put_version_in_src_embedded branch September 16, 2022 16:58
@cmdcolin cmdcolin changed the title Fix the version number reported by embedded components Fix the UMD build of the react embedded components Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants