-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the UMD build of the react embedded components #3191
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3191 +/- ##
=======================================
Coverage 59.48% 59.48%
=======================================
Files 671 671
Lines 28734 28734
Branches 6968 6968
=======================================
Hits 17092 17092
Misses 11320 11320
Partials 322 322 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
actually this only affected the storybook build. still need to properly git commit the version change in the postversion step, but it is accurately reported in e.g. our demos like https://jbrowse.org/demos/lgv/ |
6adaab3
to
9e5a7f3
Compare
just saw that! checking into it now |
5a9cefe
to
fbafc82
Compare
i think this should be fixed now. I can see on the release machine the umd bundles were never created but this branch should create them properly, and it changes postversion to prepack |
I could investigate why postversion doesn't work perhaps but i think we could go ahead and create a quick point release with this to restore UMD@latest |
the PR in #3162 did not quite work, as the version number was not updated. I should test this PR out maybe on a locally private npm publish to see if it works but this PR changes the logic a bit to use prepack instead of postversion, and commits the change
reference
https://github.com/semantic-release/semantic-release/blob/master/docs/support/FAQ.md#how-can-i-use-a-npm-build-script-that-requires-the-packagejsons-version-