Merge for expected 5.7.2 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a self-contained bootstrap configuration and setup script under .travis/
that can be run in a CI environment
Currently runs tests using PHP 5.3 against a sqlite database backend, but
this can be extended to a larger build matrix in .travis.yml by:
* Adding more versions of PHP to the php list.
* Adding more DB entries to the env list with matching bootstrap configs.
Provide a configuration for travis to run unit tests
As MySQL tables are files on disk, MySQL follows the case-sensitivity of the Operating System, so tests using mangled capitalisation fail. These may have been missed before as Oracle and MySQL on Windows are case-insensitive.
Correct capitalisation of table names in unit tests
* The tests still do not all pass * Tests against MySQL as well * Adds tests against php 5.4 (which will be the default on RHE7) and also php 5.5, which we are using in our dev enviroments. * allow sqlLite to fail test
These were found after running the unit tests against MySQL for the first time for a while. The following changes have been made: * Moved getId commnad to after flush in sampleFixtureDataa1, the id can not be gurenteed to exist until the flush has been performed. * Add flush statments to the ExtensionTest unit test. These flush the admin user after creation, ensuring that the user is in the DB for the RoleAuthorisationService to find. * Remove old commented out code from ExtensionsTest.php
As per commit 9d18a12 . The capitilisation on the database queries needs to match that which we define in the entitity definition.
Travis using MySQL
In NGI service
Removes depency of the function on the service ID
Github allows us to track changes in each release when we tag versions. So A link has been added to the top of the change log file, which will no longer be updated.
- Change to using Ubuntu Precise in Travis builds to allow PHP 5.3 tests to work. - Add Trusty build with include in matrix to check future compatibility. - Add explicit sudo options as Travis only does VM based Precise builds now.
Add Precise MySQL Travis builds
Refactor edit serviceEndpoint function
correct typo in text of exception in NGI service
Increment version and depreciate change log
Additional boolean (default false) to site and service 'notify'. Note this changes the schema, upgrades will require additional steps (see https://github.com/GOCDB/gocdb/blob/master/INSTALL.md#updateddl).
Adds ability to update the notify property of sites and services to their respective services.
Changes to the web frontend to enable the setting of a boolean for whether notifications are wanted for a given site or service.
Addition of notifications boolean to output for get_site and get_service PI outputs.
Addition of boolean to services and sites for notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.