Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-08-26 | MAIN --> PROD | DEV (aa9b1d5) --> STAGING #1955

Merged
merged 7 commits into from
Aug 26, 2023
Merged

2023-08-26 | MAIN --> PROD | DEV (aa9b1d5) --> STAGING #1955

merged 7 commits into from
Aug 26, 2023

Conversation

jadudm
Copy link
Contributor

@jadudm jadudm commented Aug 26, 2023

This is an auto-generated pull request to merge main into prod for a staging release on 2023-08-26 with the last commit being merged as aa9b1d5

jperson1 and others added 7 commits August 24, 2023 10:08
Change language for threshold on audit info form
Closes #1585

In this PR:
Adding logout command
Tweaking login command so that you can optionally specify credentials
Cypress test now logs out, then logs in with an auditee account, who then performs the auditee cert

Testing:
Cypress tests should pass
New env vars required: LOGIN_TEST_EMAIL_AUDITEE, LOGIN_TEST_PASSWORD_AUDITEE, LOGIN_TEST_OTP_SECRET_AUDITEE
This email will be used for the auditee info form and will be used to perform the auditee cert
You can use values from the FAC dev keys doc
These have been added to the GH staging env vars as well

---------

Co-authored-by: Phil Dominguez <“philip.dominguez@gsa.gov”>
Co-authored-by: Edward Zapata <edward.zapata@gsa.gov>
* Move SubmissionProgressView into its own file ahead of work on it.

* Update/refactor submission_progress_check to return new requirements, and change tests accordingly.

+   Change the logic for Submission progress to display
    complete/incomplete/inactive.
+   Change the logic for Submission progress to treat
    findings/findings text/corrective action plan as optional instead
    of always required.
+   Switch submission-checklist.html to using section_block for each
    section.
+   Switch audit/report-submission/CAP/ to audit/report-submission/cap
    hopefully everywhere.
+   Move some functions that were in sac_validation_shape.py to naming.py.

* Minor corrections.

---------

Co-authored-by: Edward Zapata <edward.zapata@gsa.gov>
@jadudm jadudm added autogenerated Automated pull request creation automerge Used for automated deployments labels Aug 26, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jadudm jadudm temporarily deployed to production August 26, 2023 10:30 — with GitHub Actions Inactive
@jadudm jadudm temporarily deployed to staging August 26, 2023 10:30 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2023

Terraform plan for staging

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Staging Environment #26

@github-actions
Copy link
Contributor

Terraform plan for production

Plan: 0 to add, 1 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.production.cloudfoundry_app.postgrest will be updated in-place
  ~ resource "cloudfoundry_app" "postgrest" {
      ~ environment                     = (sensitive value)
        id                              = "70ac44be-3507-4867-a75f-c2d1ab12ee89"
      ~ id_bg                           = "************************************" -> (known after apply)
      ~ memory                          = 128 -> 512
        name                            = "postgrest"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

📝 Plan generated in Pull Request Checks #718

@github-actions
Copy link
Contributor

File Coverage Missing
All files 89%
api/serializers.py 89% 121-122 127 132
api/test_views.py 99%
api/uei.py 96% 17-18 107-108
api/views.py 97% 187-188 195-196 217 395-396
audit/cog_agency.py 94% 49
audit/cog_over.py 53% 73-116 120-136 144
audit/etl.py 78% 55-56 73-74 107 194-200 214-235 256 271 401-430
audit/excel.py 87% 397 413 419 424 429 451-452 464 665-666 675-681 691 711
audit/forms.py 56% 22-29
audit/models.py 82% 86 155 311 329-330 338 360 417-420 449-450 454 462 471 481 484-490
audit/test_commands.py 87%
audit/test_etl.py 97% 235-250 331-334
audit/test_mixins.py 90% 112-113 117-119 184-185 189-191
audit/test_validators.py 95% 434 438 606-607 846 853 860 867
audit/utils.py 92% 12
audit/validators.py 96% 253-254 282-283 298-299 309 500-509
audit/views.py 37% 85-106 129-130 192-193 236-237 247-258 299-312 315-329 334-347 361-367 372-392 419-423 428-457 497-501 506-526 553-557 562-591 631-635 640-652 655-666 671-683 696-697 702-751 754-791 794-811
audit/cross_validation/additional_ueis.py 93% 33
audit/cross_validation/check_award_ref_declaration.py 90%
audit/cross_validation/check_award_reference_uniqueness.py 93%
audit/cross_validation/check_findings_count_consistency.py 91%
audit/cross_validation/check_ref_number_in_cap.py 90%
audit/cross_validation/check_ref_number_in_findings_text.py 90%
audit/cross_validation/errors.py 78% 30 61
audit/cross_validation/naming.py 50% 167-171
audit/cross_validation/submission_progress_check.py 82% 62 77-80
audit/cross_validation/tribal_data_sharing_consent.py 86% 20
audit/fixtures/single_audit_checklist.py 86% 155 229-235
audit/management/commands/load_fixtures.py 46% 39-44
audit/viewlib/submission_progress_view.py 96% 158-159
audit/viewlib/upload_report_view.py 31% 31-34 43 90-110 113-178
cms/views.py 57% 11-16 29-30
config/urls.py 71% 87
dissemination/models.py 99% 685
report_submission/forms.py 90% 9
report_submission/views.py 72% 82 191-193 195 201-308 311-321
report_submission/templatetags/get_attr.py 76% 8 11-14 18
tools/update_program_data.py 89% 96
users/auth.py 95% 39-40
users/fixtures/user_fixtures.py 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against aa9b1d5

@jadudm jadudm merged commit 128fa38 into prod Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autogenerated Automated pull request creation automerge Used for automated deployments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants