Evaluation Form: Limit criteria points / weight field input to 4 digits

[stepchud]

As a user, I want to enter reasonable numbers for criteria points / weight.

Based on Feedback from QA, this number is not limited in the UI and it can cause errors. We should restrict the input to 4 digits (<= 9999) and <= 100 for weighted scale.

Technical Notes

Could use HTML input max attribute here

Acceptance Criteria

• User can not enter more than 4 digits for criteria points
• Scores for weighted (%) criteria must be <= 100
• When the user switches between Scale Types, the form should remain interactive and enable the user to fix any validation issues and make changes to the form as necessary (see bug report below)

Disregard the following if this work does not include any UI changes

• WAVE screenshot
• Automated a11y tests (axe-rspec specs)
• Keyboard accessibility (tab navigation, form interactions)
• Responsiveness at desktop and mobile

Out of Scope

[stepchud]

There is still an issue with the collapsible criteria accordion.

Steps to reproduce:

1. Create a form with Point Scale Type
2. Add a criteria worth more than 100 points
3. Collapse the criteria
4. Switch the form to Weighted Scale Type

Expected:

• User should be able to expand the accordion to adjust scoring
• User should see validation error message related to the invalid score weight

Actual:

• The accordion can't be expanded
• The form can't be saved because it is invalid
• There is no error feedback to the user because the row is collapsed

[stepchud]

☝️ @cpreisinger Can you take a look at the issue in the comment above?