[275-FIX] Fix for max input values for scale types #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
stepchud
reviewed
Nov 26, 2024
…com:GSA/Challenge_platform into 275-fix/evaluation-form-weight-points-limit * '275-fix/evaluation-form-weight-points-limit' of github.com:GSA/Challenge_platform: [183] Rubocop: enable documentation cop (#282) 230 Dependent destroy for assignment evaluations 230 Add evaluation association to assignment update schema annotation 230 Fix evaluation submission assignment spec 230 Remove status, add submission assignment 230 Add submissions and constraints to evalutions 230 Fix codeclimate comment validation errors 230 Initial commit of evaluation and score backend
cpreisinger
added a commit
that referenced
this pull request
Dec 10, 2024
…-form-cancelation-modal * 'dev' of github.com:GSA/Challenge_platform: (52 commits) [275-FIX] Fix for max input values for scale types (#288) Update app/views/evaluator_submission_assignments/_unassigned_submission_row.html.erb Update .codeclimate.yml rubocop name Disable rubocop check on flash before render quick syntax fix 179 | Adjust sorting scope and evaluation status quick syntax fix update status colors 179 | Adjust sorting scope and evaluation status Rename stat summary for evaluation submission assignments 179 | Add tests, update statuses, and colors 179 | Update flash, closing date, and error status 179 | Update tests for display scores 179 | Remove unused argument in display_score 179 | Update tests wip 179 | Update ordered by status query 179 | Update the display score to check for assignment completion 179 | Update js to use assignment 179 | Update route for evaluation submission assignments 77 | Update recused conditional ...
cpreisinger
added a commit
that referenced
this pull request
Dec 10, 2024
…SA/Challenge_platform into 249/protect-eval-form-after-start-date * '249/protect-eval-form-after-start-date' of github.com:GSA/Challenge_platform: (53 commits) 249 Protect eval form updates after start_date [275-FIX] Fix for max input values for scale types (#288) Update app/views/evaluator_submission_assignments/_unassigned_submission_row.html.erb Update .codeclimate.yml rubocop name Disable rubocop check on flash before render quick syntax fix 179 | Adjust sorting scope and evaluation status quick syntax fix update status colors 179 | Adjust sorting scope and evaluation status Rename stat summary for evaluation submission assignments 179 | Add tests, update statuses, and colors 179 | Update flash, closing date, and error status 179 | Update tests for display scores 179 | Remove unused argument in display_score 179 | Update tests wip 179 | Update ordered by status query 179 | Update the display score to check for assignment completion 179 | Update js to use assignment 179 | Update route for evaluation submission assignments ...
cpreisinger
added a commit
that referenced
this pull request
Dec 11, 2024
…enge_platform into 237/eval-form-phase-uniqueness * '237/eval-form-phase-uniqueness' of github.com:GSA/Challenge_platform: (56 commits) 237 Add unique phase constraint on eval forms Bump rubocop from 1.68.0 to 1.69.1 Bump selenium-webdriver from 4.26.0 to 4.27.0 [304] Collapsible Column Layout (#310) [275-FIX] Fix for max input values for scale types (#288) Update app/views/evaluator_submission_assignments/_unassigned_submission_row.html.erb Update .codeclimate.yml rubocop name Disable rubocop check on flash before render quick syntax fix 179 | Adjust sorting scope and evaluation status quick syntax fix update status colors 179 | Adjust sorting scope and evaluation status Rename stat summary for evaluation submission assignments 179 | Add tests, update statuses, and colors 179 | Update flash, closing date, and error status 179 | Update tests for display scores 179 | Remove unused argument in display_score 179 | Update tests wip 179 | Update ordered by status query ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this PR I ended up expanding all the accordions and just blanking all points/weights if two conditions were met
A confirmation alert also shows up currently and prevents scale type switching if it isn't confirmed
An additional update on this PR was changing the way the inputs worked for points/weight to validate their length on blur using
reportValidityHTML5 validations. This was to prevent being able to temporarily circumvent min and max values by typingPossible alteration to make it more inline with the initial comment if we want would be:
#275