[179] View Evaluator's Submissions #258

emmabjj · 2024-11-07T18:37:27Z

Related tickets: #179, #76, #74

Add UI to view evaluators' submissions from the manage evaluator index page.

View Evaluator's Submissions #179
Allows a challenge manager to view the assigned and unassigned submissions of an evaluator for a particular phase. The different statuses for an evaluator's assigned submissions are either "recused", "in progress", "not started", or "completed".
A challenge manager will be able to see the total assigned challenge submissions, the evaluation's due date (the phase's end date), and the number of evaluations completed, in progress, and not started
For each assigned submission, a challenge manager will see the submission ID, the evaluation status, the evaluator's score (WIP), and an option to unassign or view an evaluation.
For each unassigned submission, a challenge manager will see the submission ID, the evaluation status (unassigned WIP), the evaluator's score (WIP), and an option to reassign the submission to the evaluator.

Add UI and functionality for the Unassign Evaluator from a Submission modal and add functionality to reassign a submission to an evaluator.

Unassign Evaluators from a Submission #76

I've added controller tests - other tests WIP. The UI is responsive.

Mobile

…ugh submissions

…ons_view

config/routes.rb

…ons_view

stepchud

initial feedback on route and controller

config/routes.rb

app/controllers/evaluator_submission_assignments_controller.rb

app/helpers/evaluators_helper.rb

feedback addressed

stepchud · 2024-11-26T22:56:02Z

app/models/evaluator_submission_assignment.rb

+    assigned: 0,
+    unassigned: 1,
+    recused: 2,
+    not_started: 3,


how are assigned and not_started statuses different? I left a comment here about the status of the assignment/evaluation progress WRT not_started, in_progress and completed. here are some examples of queries that filter on those statuses (that PR isn't merged yet).

I think I'd prefer to stick with that approach for now because it is easier than keeping the status updated in all cases of progress. let me know if it doesn't make sense here.

stepchud · 2024-11-26T23:57:59Z

app/controllers/evaluator_submission_assignments_controller.rb

+  end
+
+  def handle_successful_update(new_status)
+    flash.now[:success] = t("evaluator_submission_assignments.#{new_status}.success")


I think the flash.now[:success] should be flash[:success] since you are redirecting to the next page

yeah I tested this and I don't see the message unless it used flase[:success], unfortunately there is some rubocop linter warning about this but you should disable that cop for these line.

stepchud · 2024-11-26T23:58:12Z

app/controllers/evaluator_submission_assignments_controller.rb

+  end
+
+  def handle_failed_update(new_status)
+    flash.now[:error] = t("evaluator_submission_assignments.#{new_status}.failure")


same here, use flash[:error]

stepchud · 2024-11-27T00:09:58Z

app/javascript/controllers/unassign_evaluator_submission_modal_controller.js

+        const evaluatorId = new URLSearchParams(window.location.search).get('evaluator_id');
+        window.location.href = `/phases/${this.phaseIdValue}/evaluator_submission_assignments?evaluator_id=${evaluatorId}`;


this is essentially doing location.reload() right? I have a different idea, what if you redirect to the path provided in the response data. you could render the url in the response JSNO as data.redirect_to or something and then reuse that same redirect path for both success and error since the backend will determine where to send the user. I think this will also display the flash message that was stored after the browser redirects, so you may not need the alert() either. if you want you can still log a console.error() for developer debugging help messages.

Suggested change

const evaluatorId = new URLSearchParams(window.location.search).get('evaluator_id');

window.location.href = `/phases/${this.phaseIdValue}/evaluator_submission_assignments?evaluator_id=${evaluatorId}`;

window.location.href = data.redirect_to;

stepchud · 2024-11-27T00:25:15Z

app/javascript/controllers/unassign_evaluator_submission_modal_controller.js

+        'Accept': 'application/json'
+      },
+      body: JSON.stringify({
+        status: 'unassigned'


I tried modifying this value to send some unknown, invalid status to the backend to trigger an error but it caused a 500 exception instead in the model update. You can remedy this by validating the status param in the rails controller before trying to update the model with an invalid value. if the client sends an invalid status, reject the request with :unprocessable_entity status.

.. alternatively you could rescue errors from the @assignment.update call in the controller to return false

stepchud · 2024-11-27T00:35:06Z

app/views/evaluator_submission_assignments/_submission_summary.html.erb

+              Assigned Submissions
+            </h3>
+            <p class="usa-summary-box__text text-primary-darker text-bold">
+              Evaluations due by <%= @phase.end_date.strftime('%m/%d/%Y') %>


evaluations are due by the form's closing_date. there are a few other stats collection examples on #280, although there are subtle differences in the two components.

Suggested change

Evaluations due by <%= @phase.end_date.strftime('%m/%d/%Y') %>

Evaluations due by <%= @phase.evaluation_form.closing_date.strftime('%m/%d/%Y') %>

stepchud · 2024-11-27T00:36:14Z

app/views/evaluator_submission_assignments/_submission_summary.html.erb

this is a little nitpicky, but can we rename this _assignments_stats.html.erb just for consistency with the other stats component on #280?

stepchud · 2024-11-27T00:39:58Z

app/views/evaluator_submission_assignments/_submission_table.html.erb

that's a cool use of layout 👍

stepchud · 2024-11-27T00:48:09Z

app/views/evaluator_submission_assignments/index.html.erb

+  <%= render 'submission_summary', assigned_count: @assigned_submissions.count, 
+                                   submissions_count: @submissions_count, 
+                                   phase_end_date: @phase.end_date %>


these local assigns are unused and not needed

Suggested change

<%= render 'submission_summary', assigned_count: @assigned_submissions.count,

submissions_count: @submissions_count,

phase_end_date: @phase.end_date %>

<%= render 'submission_summary' %>

stepchud · 2024-11-27T00:51:27Z

app/views/evaluator_submission_assignments/_submission_row.html.erb

+<tr data-evaluator-id="<%= evaluator.id %>" data-evaluator-type="user">
+  <td data-label="Submission ID" class="text-top text-bold"><%= assignment.submission.id %></td>
+  <td data-label="Evaluation status">
+    <span class="text-top text-bold <%= evaluation_status(assignment.status) %>"><%= assignment.status.titleize %></span>


did you try using the uswds tag here (with color)?

stepchud · 2024-11-27T00:59:15Z

app/views/shared/_back_link.html.erb

+<div class="margin-bottom-2 margin-top-3">
+  <%= link_to path, class: "usa-link display-inline-flex flex-align-center" do %>
+    <%= image_tag('images/usa-icons/arrow_back.svg', class: "usa-icon--size-3", alt: "Back to previous page") %>
+    <span class="margin-left-05 text-primary"><%= 'Back' %></span>


Why is 'Back' interpolated?

Suggested change

<span class="margin-left-05 text-primary"><%= 'Back' %></span>

<span class="margin-left-05 text-primary">Back</span>

stepchud · 2024-11-27T01:14:48Z

spec/requests/evaluator_submission_assignments_spec.rb

let's add a request spec for the #index route here and also spec/system/evaluator_submission_assignment_spec.rb with a11y expect(page).to be_axe_clean and some page interactions assigning and unassigning evaluators with confirmation modal.

emmabjj added 14 commits November 4, 2024 13:54

245 | Update invited evaluator user setup

7abaa15

245 | Move evaluator invitation to evaluator user logic

2093119

245 | Add check for evaluator's role

6771cf4

245 | Remove duplicate logic and handle in/valid evaluator roles

ef02ade

245 | Add successfully removed flash notice back in

23e5701

245 | Update tests

27f35d0

245 | CPE created automatically, adjust redudant conditional

e64fa23

179 | UI/Add view for evaluator submissions

1d36e0d

179 | Add UI for the unassign modal and js

d576fa0

179 | Add routes

a91e88a

179 | Add evaluator_submissions_assignments association to phase thro…

a4a9298

…ugh submissions

179 | Add evaluation submissions controller

742af61

179 | Add evaluation status text colors

44c2db5

179 | Add evaluation status order

145886a

emmabjj self-assigned this Nov 7, 2024

emmabjj added 2 commits November 7, 2024 12:40

Merge branch '200_manage_evaluators_list' into 179_evaluator_submissi…

16866fb

…ons_view

179 | Add evaluator submissions message translations

4295f4d

emmabjj requested a review from stepchud November 7, 2024 20:32

stepchud reviewed Nov 19, 2024

View reviewed changes

config/routes.rb Outdated Show resolved Hide resolved

Merge branch '200_manage_evaluators_list' into 179_evaluator_submissi…

3f803d3

…ons_view

Base automatically changed from 200_manage_evaluators_list to dev November 20, 2024 00:27

emmabjj added 7 commits November 22, 2024 12:13

179 | Update routes

8775c82

179 | Update view and use partials

a68e0cb

179 | Use update for reassign & unassign

5c5ad7e

179 | Add recused_unassigned status

e86b23e

179 | Back link partial

fbe433a

179 | Adjust js to use patch update on status reassign/unassign

3ff0089

179 | Add to translations

e7882bf

emmabjj changed the title ~~WIP - [179] View Evaluator's Submissions~~ [179] View Evaluator's Submissions Nov 22, 2024

Small updates

9c89936

Update ordered by status

e541c13

emmabjj marked this pull request as ready for review November 22, 2024 19:28

emmabjj requested a review from stepchud November 22, 2024 19:28

Merge branch 'dev' into 179_evaluator_submissions_view

25f0d6d

r-bartlett-gsa added this to the Sprint 12/03/24 milestone Nov 22, 2024

This was linked to issues Nov 22, 2024

View Evaluator's Submissions #179

Open

Unassign Evaluators from a Submission #76

Open

emmabjj added 4 commits November 22, 2024 15:22

179 | Display score for evaluator submission assignments

8e207e1

179 | Adjust SQL statement for status order

f0013f6

179 | Scope score to evaluator's evaluation score

6602fb3

179 | Recused unassigned cannot be reassign to the submission

9f44ad8

stepchud previously requested changes Nov 22, 2024

View reviewed changes

emmabjj added 8 commits November 25, 2024 16:49

179 | Update route for evaluation submission assignments

d029c20

179 | Update js to use assignment

c890db4

179 | Update the display score to check for assignment completion

01209a4

179 | Update ordered by status query

ec365f9

179 | Update tests wip

575eda4

179 | Remove unused argument in display_score

f824247

179 | Update tests for display scores

d99a8b4

Merge branch 'dev' into 179_evaluator_submissions_view

28e77ea

stepchud reviewed Nov 27, 2024

View reviewed changes

app/views/evaluator_submission_assignments/_submission_table.html.erb

Copy link

Contributor

stepchud Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a cool use of layout 👍

stepchud reviewed Nov 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[179] View Evaluator's Submissions #258

[179] View Evaluator's Submissions #258

emmabjj commented Nov 7, 2024

stepchud left a comment

stepchud Nov 26, 2024

stepchud Nov 26, 2024

stepchud Nov 27, 2024

stepchud Nov 26, 2024

stepchud Nov 27, 2024 •

edited

Loading

stepchud Nov 27, 2024

stepchud Nov 27, 2024

stepchud Nov 27, 2024

stepchud Nov 27, 2024

stepchud Nov 27, 2024

stepchud Nov 27, 2024

stepchud Nov 27, 2024

stepchud Nov 27, 2024

stepchud Nov 27, 2024

		const evaluatorId = new URLSearchParams(window.location.search).get('evaluator_id');
		window.location.href = `/phases/${this.phaseIdValue}/evaluator_submission_assignments?evaluator_id=${evaluatorId}`;

	const evaluatorId = new URLSearchParams(window.location.search).get('evaluator_id');
	window.location.href = `/phases/${this.phaseIdValue}/evaluator_submission_assignments?evaluator_id=${evaluatorId}`;
	window.location.href = data.redirect_to;

	Evaluations due by <%= @phase.end_date.strftime('%m/%d/%Y') %>
	Evaluations due by <%= @phase.evaluation_form.closing_date.strftime('%m/%d/%Y') %>

	<span class="margin-left-05 text-primary"><%= 'Back' %></span>
	<span class="margin-left-05 text-primary">Back</span>

[179] View Evaluator's Submissions #258

Are you sure you want to change the base?

[179] View Evaluator's Submissions #258

Conversation

emmabjj commented Nov 7, 2024

Add UI to view evaluators' submissions from the manage evaluator index page.

Add UI and functionality for the Unassign Evaluator from a Submission modal and add functionality to reassign a submission to an evaluator.

Mobile

stepchud left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stepchud Nov 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stepchud Nov 27, 2024 •

edited

Loading