[209] Submission Stats #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepchud
force-pushed
the
209_submission_stats
branch
from
68d7200
to
cfeabcc
Compare
|
This will be updated with status from the |
stepchud
force-pushed
the
209_submission_stats
branch
from
cfeabcc
to
e5c9c0f
Compare
stepchud
requested changes
Nov 26, 2024
There was a problem hiding this comment.
(I think) I made the necessary code changes as far as the stats component calculations and display. However, I would like to see some tests for this component. They should mostly be request specs in spec/requests/submissions_spec.rb that assert the various stats are displayed correctly. Can we also add a spec/system/submissions_spec.rb expectation that the stats show visible content on the page.
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a stats component to the submissions list page for challenge managers.