[209] Submission Stats #280
Conversation
stepchud
force-pushed
the
209_submission_stats
branch
from
68d7200 to
cfeabcc
Compare
|
This will be updated with status from the |
stepchud
force-pushed
the
209_submission_stats
branch
from
cfeabcc to
e5c9c0f
Compare
There was a problem hiding this comment.
(I think) I made the necessary code changes as far as the stats component calculations and display. However, I would like to see some tests for this component. They should mostly be request specs in spec/requests/submissions_spec.rb that assert the various stats are displayed correctly. Can we also add a spec/system/submissions_spec.rb expectation that the stats show visible content on the page.
Co-authored-by: Stephen Chudleigh <stepchud@users.noreply.github.com>
spec/requests/submissions_spec.rb
Outdated
| submission = create(:submission, challenge: challenge, phase: phase) | ||
| submission_2 = create(:submission, challenge: challenge, phase: phase, judging_status: "selected") |
There was a problem hiding this comment.
| submission = create(:submission, challenge: challenge, phase: phase) | |
| submission_2 = create(:submission, challenge: challenge, phase: phase, judging_status: "selected") | |
| create(:submission, challenge: challenge, phase: phase) | |
| create(:submission, challenge: challenge, phase: phase, judging_status: "selected") |
spec/requests/submissions_spec.rb
Outdated
| get submissions_phase_path(phase) | ||
| expect(response.body).to include("Boston Tea Party Cleanup") | ||
| # total submissions | ||
| expect(response.body).to include("2") |
There was a problem hiding this comment.
this is not testing much since the expect below also has a 2 in it, but I found a way to use css selectors that gives more specific expectations. the trick is to include Capybara::RSpecMatchers in the request specs to enable the have_css() matcher. I'll add this now.
#209
Adds a stats component to the submissions list page for challenge managers.