This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Add Amazon SES (Simple Email Service) #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
#20 is merged now... Can you rebase? |
Co-authored-by: Bret Mogilefsky <bret.mogilefsky@gsa.gov>
Co-authored-by: Bret Mogilefsky <bret.mogilefsky@gsa.gov>
mogul
reviewed
May 13, 2021
Comment on lines
+38
to
+44
| - name: Set the instance name for subsequent steps | ||
| # Use an instance name that corresponds to this particular branch+run. | ||
| # Docs for this method: | ||
| # https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable | ||
| run: | | ||
| INSTANCE_NAME="$(echo ci-${{ github.event.pull_request.number }}-${GITHUB_RUN_ID})" | ||
| echo "INSTANCE_NAME=${INSTANCE_NAME}" | tee -a $GITHUB_ENV |
There was a problem hiding this comment.
This env var is used in the Makefile for the eks-brokerpak and datagov-brokerpak, but it has no purpose here, so these lines can be removed.
mogul
approved these changes
May 13, 2021
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It output a SMTP server address, username and password.
Also added github actions in
.github/workflowsto release a new brokerpak file upon a new tag is created.