Add system-characteristics 'categorization-has' constraints #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabeblis
force-pushed
the
constraints/system-characteristics/categorization-has
branch
2 times, most recently
from
bec0eb1
to
e6a1686
Compare
|
@Gabeblis is out of office, so I will rebase this PR again recent changes to the target branch so I can complete a review and potentially merge. |
aj-stein-gsa
force-pushed
the
constraints/system-characteristics/categorization-has
branch
from
e6a1686
to
91eb95b
Compare
|
Sigh, I borked the rebase. 🤦 Will have to go for a take two! Assigning myself as the guilty party for now. |
Gabeblis
force-pushed
the
constraints/system-characteristics/categorization-has
branch
from
91eb95b
to
5ee358a
Compare
@aj-stein-gsa I successfully rebased onto the target branch. |
aj-stein-gsa
previously approved these changes
Sep 16, 2024
aj-stein-gsa
previously approved these changes
Sep 16, 2024
aj-stein-gsa
force-pushed
the
constraints/system-characteristics/categorization-has
branch
from
2caa772
to
22f1615
Compare
aj-stein-gsa
approved these changes
Sep 17, 2024
aj-stein-gsa
merged commit 65f2030
into
GSA:feature/external-constraints
3 checks passed
aj-stein-gsa
added a commit
that referenced
this pull request
Sep 24, 2024
* Added system-characteristics 'categorization-has constraints and tests * Adjust path style and message wording per my PR feedback --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
aj-stein-gsa
added a commit
that referenced
this pull request
Sep 25, 2024
* Added system-characteristics 'categorization-has constraints and tests * Adjust path style and message wording per my PR feedback --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
Rene2mt
pushed a commit
to Rene2mt/fedramp-automation
that referenced
this pull request
Sep 27, 2024
* Added system-characteristics 'categorization-has constraints and tests * Adjust path style and message wording per my PR feedback --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
brian-ruf
pushed a commit
to brian-ruf/fedramp-automation
that referenced
this pull request
Nov 8, 2024
* Added system-characteristics 'categorization-has constraints and tests * Adjust path style and message wording per my PR feedback --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
This was referenced Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Description
Added system-characteristics 'categorization-has' constraints and tests for each of the constraints. These should be added as they are part of the effort write all of the constraints from the constraint tracker.
Changes
{Please provide a description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please submit the PR as a draft PR using the "Draft pull request" dropdown.}
All Submissions:
If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.