Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system-characteristics 'categorization-has' constraints #671

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Add system-characteristics 'categorization-has' constraints #671

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ee358a
Added system-characteristics 'categorization-has constraints and tests
Gabeblis Sep 10, 2024
22f1615
Adjust path style and message wording per my PR feedback
aj-stein-gsa Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions features/fedramp_extensions.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ Examples:
| attachment-type-PASS.yaml |
| authorization-type-FAIL.yaml |
| authorization-type-PASS.yaml |
| categorization-has-correct-system-attribute-FAIL.yaml |
| categorization-has-correct-system-attribute-PASS.yaml |
| categorization-has-information-type-id-FAIL.yaml |
| categorization-has-information-type-id-PASS.yaml |
| cloud-service-model-FAIL.yaml |
| cloud-service-model-PASS.yaml |
| component-type-FAIL.yaml |
Expand Down Expand Up @@ -91,6 +95,8 @@ Examples:
| address-type |
| attachment-type |
| authorization-type |
| categorization-has-correct-system-attribute |
| categorization-has-information-type-id |
| cloud-service-model |
| component-type |
| control-implementation-status |
Expand Down
2 changes: 1 addition & 1 deletion src/validations/constraints/content/ssp-all-INVALID.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<p>Contains sensitive financial data related to organizational operations.</p>
</description>
<categorization system="https://unsupported-system.com">
<information-type-id>C.2.8.12</information-type-id>
<!-- Removed information-type-id to ensure that categorization-has-information-type-id fails correctly. -->
</categorization>
<confidentiality-impact>
<base>high</base>
Expand Down
6 changes: 6 additions & 0 deletions src/validations/constraints/fedramp-external-constraints.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@
<expect id="has-separation-of-duties-matrix" target="back-matter" test="resource[prop[@name eq 'type' and @value eq 'separation-of-duties-matrix']]" level="ERROR">
<message>A FedRAMP SSP must have a Separation of Duties Matrix attached.</message>
</expect>
<expect id="categorization-has-correct-system-attribute" target="//system-characteristics" test="system-information/information-type/categorization/@system eq 'https://doi.org/10.6028/NIST.SP.800-60v2r1'" level="ERROR">
aj-stein-gsa marked this conversation as resolved.
Show resolved Hide resolved
<message>A FedRAMP SSP information-type categorization lacks a correct system attribute. The correct value is "https://doi.org/10.6028/NIST.SP.800-60v2r1".</message>
aj-stein-gsa marked this conversation as resolved.
Show resolved Hide resolved
</expect>
<expect id="categorization-has-information-type-id" target="//system-characteristics" test="system-information/information-type/categorization/information-type-id" level="ERROR">
<message>A FedRAMP SSP information type categorization must have at least one information type identifier.</message>
</expect>
</constraints>
</context>
<context>
Expand Down
9 changes: 9 additions & 0 deletions src/validations/constraints/unit-tests/categorization-has-correct-system-attribute-FAIL.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Negative Test for categorization-has-correct-system-attribute
description: >-
This test case validates the behavior of constraint
categorization-has-correct-system-attribute
content: ../content/ssp-all-INVALID.xml
expectations:
- constraint-id: categorization-has-correct-system-attribute
result: fail
9 changes: 9 additions & 0 deletions src/validations/constraints/unit-tests/categorization-has-correct-system-attribute-PASS.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Positive Test for categorization-has-correct-system-attribute
description: >-
This test case validates the behavior of constraint
categorization-has-correct-system-attribute
content: ../content/ssp-all-VALID.xml
expectations:
- constraint-id: categorization-has-correct-system-attribute
result: pass
9 changes: 9 additions & 0 deletions src/validations/constraints/unit-tests/categorization-has-information-type-id-FAIL.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Negative Test for categorization-has-information-type-id
description: >-
This test case validates the behavior of constraint
categorization-has-information-type-id
content: ../content/ssp-all-INVALID.xml
expectations:
- constraint-id: categorization-has-information-type-id
result: fail
9 changes: 9 additions & 0 deletions src/validations/constraints/unit-tests/categorization-has-information-type-id-PASS.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Positive Test for categorization-has-information-type-id
description: >-
This test case validates the behavior of constraint
categorization-has-information-type-id
content: ../content/ssp-all-VALID.xml
expectations:
- constraint-id: categorization-has-information-type-id
result: pass
Loading