Add three SSP metadata role constraints #676

DimitriZhurkin · 2024-09-10T17:51:28Z

Committer Notes

Add the following three constraints:

role-defined-authorizing-official-poc
role-defined-information-system-security-officer
role-defined-system-poc-other

All Submissions:

Have you selected the correct base branch per Contributing guidance?
Have you set "Allow edits and access to secrets by maintainers"?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you squashed any non-relevant commits and commit messages? [instructions]
Have you added an explanation of what your changes do and why you'd like us to include them?
If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?
If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

…atibility breaking changes introduced in the 1.2.1 oscal content release. This approach uses a local catalog that contains these fixes.

Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>

…ersion Local version of SP800-53rev5.1.1 that contains the correct labels

Adding the March 7 Data Bites presentation

Add files via upload

Uploading April's Data Bites presentation

Uploading the most recent Data Bites presentation

Add files via upload

Adding recent Data Bites presentations

* Fix OSCAL version * Move submodule to v1.0.6 * Remove USWDS * Fix validation errors in rev 4 templates

* Add files via upload Adding recent Data Bites presentations * Add files via upload

Fix invalid error (<prop name="privilege-level" value="privileged"/>)

This reverts commit 89f6c35.

Fix invalid error (<prop name="privilege-level" value="privileged"/>)

This reverts commit 89f6c35.

…itriZhurkin/fedramp-automation into feature/external-constraints

Add **validations** as one of the "This relates to..." options

Add the following constraints: 1. role-defined-authorizing-official-poc 2. role-defined-information-system-security-officer 3. role-defined-system-poc-other

aj-stein-gsa · 2024-09-10T19:46:53Z

src/scripts/dev-constraint.cjs

-    let scenarioLines = getScenarioLineNumbers(featureFile, constraintId,testFiles);
+    const scenarioLines = getScenarioLineNumbers(featureFile, constraintId,testFiles);

    if (scenarioLines.length === 0) {
        console.error(`No scenarios found for constraintId: ${constraintId}`);
-        execSync("npm run test:coverage",{stdio:'ignore'});
-        scenarioLines = getScenarioLineNumbers(featureFile, constraintId,testFiles);
-        if(scenarioLines.length===0){
+        execSync("npm run test:coverage",{stdio:'inherit'});
        return false;
-        }
    }


Non-blocking: can we explain why these changes were made and what the intended goal is? These changes seem separate of a constraint update, so I want to check we know what we're doing here and if it is necessary now.

Hmm, I'm not sure where these changes came from. I have not modified the dev-constraint.cjs file.

If you know how to revert individual file changes from a commit, please do so. Otherwise, I read out the diff output to make a suggestion, just accept this change and I think you will get it back to the way it was. Let me know. If successful, there will be no change on this file afterward.

Suggested change

let scenarioLines = getScenarioLineNumbers(featureFile, constraintId,testFiles);

const scenarioLines = getScenarioLineNumbers(featureFile, constraintId,testFiles);

if (scenarioLines.length === 0) {

console.error(`No scenarios found for constraintId: ${constraintId}`);

execSync("npm run test:coverage",{stdio:'ignore'});

scenarioLines = getScenarioLineNumbers(featureFile, constraintId,testFiles);

if(scenarioLines.length===0){

execSync("npm run test:coverage",{stdio:'inherit'});

return false;

}

}

let scenarioLines = getScenarioLineNumbers(featureFile, constraintId,testFiles);

if (scenarioLines.length === 0) {

console.error(`No scenarios found for constraintId: ${constraintId}`);

execSync("npm run test:coverage",{stdio:'ignore'});

scenarioLines = getScenarioLineNumbers(featureFile, constraintId,testFiles);

if(scenarioLines.length===0){

return false;

}

}

I don't even see that file in my commit, and I couldn't find when it had been changed in history.

AJ,

I think Paul had made these changes some time ago, and when I pulled the repo yesterday, it overwrote dev-constraint.cjs on my local system.

Then, when I pushed my constraints today, the push also picked up the modified dev-constraint.cjs file.

It's a bit confusing now, which version of dev-constraint.cjs is correct. Might wanna wait for Paul's input on that puppy.

Perhaps it is a rebase issue (where you made a branch of your PR code from a copy of feature/external-constraints, but slightly old). So do not worry about it, I can look. I will resolve this when it is approved so I do not forget to check. Re the code I don't want to change functionality and revert the Javascript because it may bork the tests for you and others if not careful, so I totally agree.

yes looks like an out dated version of the dev constraint script, that line is meant to handle the case where a new constraint is made but the full test runner hasn't been run and the feature file needs to be updated. but its best to rebase or leave as is on the feature/external-constraints, it shouldn't alter how the tests run at all since it is a different path

src/validations/constraints/fedramp-external-constraints.xml

aj-stein-gsa

Looks good, but I too have questions about role-defined-system-poc-other.

aj-stein-gsa · 2024-09-11T01:14:58Z

src/validations/constraints/fedramp-external-constraints.xml

+            </expect>
+        	<expect id="role-defined-system-poc-other" target="metadata" test="role[@id eq 'system-poc-other']" level="ERROR">
+                <message>SSP metadata must have the system other POC role.</message>
+            </expect>


This PR looks good and the others roles make sense, I looked up current docs and will need to do some history study in old Schematron and pre-website docs, I have never seen a requirement for this role before. I see you noted the same in the spreadsheet. Can we discuss this tomorrow morning?

I also have doubts about this system-poc-other role.
I couldn't find it in the rev 5 documentation at all. Wonder if it has been deprecated.

* Create 0006-testing-harness-approach.md * Create adr_template.md * Update adr_template.md Add instructions in ADR template * Update ADR-006 with decision * Update and finalize ADR 6 since it is defacto adopted We can always make a new ADR, but I have been here a few weeks and our Cucumber testing infra is largely built out, so at this point it makes sense to mark it accepted and clear up the review queue for other PRs that are less established. --------- Co-authored-by: A.J. Stein <alexander.stein@gsa.gov>

…ints

aj-stein-gsa · 2024-09-11T18:46:56Z

I am going to close this out in favor of #686. Thanks for the update, Dimtri.

* Update SSP metadata role constraints * Adjust message text to be more approachable, per PR feedback --------- Co-authored-by: A.J. Stein <aj@gsa.gov>

david-waltermire and others added 23 commits February 6, 2024 11:36

Updates to the SP 800-53 rev5.1.1 OSCAL catalog to fix backwards comp…

813fb14

…atibility breaking changes introduced in the 1.2.1 oscal content release. This approach uses a local catalog that contains these fixes.

syncing with the latest version in the NIST OSCAL content repo.

197aa99

Updating generated baseline content based on source changes.

b5f530e

Apply suggestions from code review

5ea710a

Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>

Merge pull request GSA#540 from david-waltermire/sp800-53rev5-local-v…

8c9f8af

…ersion Local version of SP800-53rev5.1.1 that contains the correct labels

Publishing auto-converted artifacts

af7764f

Add files via upload

fe944d4

Adding the March 7 Data Bites presentation

Merge pull request GSA#567 from jjahearn22/master

8bccf91

Add files via upload

Add files via upload

8663e4b

Uploading April's Data Bites presentation

Add files via upload

3fe26c1

Uploading the most recent Data Bites presentation

Merge pull request GSA#586 from jjahearn22/master

ac0a47f

Add files via upload

Add files via upload (GSA#623)

3be087d

Adding recent Data Bites presentations

Feature profiles hotfix issue 563 (GSA#591)

2ecb849

* Fix OSCAL version * Move submodule to v1.0.6 * Remove USWDS * Fix validation errors in rev 4 templates

Adding Most Recent Data Bites presentation (GSA#651)

84dd561

* Add files via upload Adding recent Data Bites presentations * Add files via upload

Fix ssp-all-VALID.xml invalid error

ec28ea5

Fix invalid error (<prop name="privilege-level" value="privileged"/>)

Revert "Improve test runner and make commands (GSA#649)"

eaca0c5

This reverts commit 89f6c35.

Revert ssp-all-VALID.xml changes

7157f5d

Fix ssp-all-VALID.xml invalid error

69b993d

Fix invalid error (<prop name="privilege-level" value="privileged"/>)

Revert "Improve test runner and make commands (GSA#649)"

2dcad00

This reverts commit 89f6c35.

Revert ssp-all-VALID.xml changes

b36fbd4

Merge branch 'feature/external-constraints' of https://github.com/Dim…

790b617

…itriZhurkin/fedramp-automation into feature/external-constraints

Update issue template 3 (GSA#641)

663e0ca

Add **validations** as one of the "This relates to..." options

Add three SSP metadata constraints

458be2e

Add the following constraints: 1. role-defined-authorizing-official-poc 2. role-defined-information-system-security-officer 3. role-defined-system-poc-other

DimitriZhurkin requested a review from a team as a code owner September 10, 2024 17:51

aj-stein-gsa reviewed Sep 10, 2024

View reviewed changes

aj-stein-gsa requested changes Sep 10, 2024

View reviewed changes

src/validations/constraints/fedramp-external-constraints.xml Show resolved Hide resolved

src/validations/constraints/fedramp-external-constraints.xml Show resolved Hide resolved

aj-stein-gsa reviewed Sep 11, 2024

View reviewed changes

Rene2mt and others added 3 commits September 10, 2024 22:31

Merge remote-tracking branch 'upstream' into feature/external-constra…

c5c4942

…ints

Merge remote-tracking branch 'upstream' into feature/external-constra…

581c35b

…ints

DimitriZhurkin mentioned this pull request Sep 11, 2024

Update SSP metadata role constraints (#676) #686

Merged

6 tasks

aj-stein-gsa closed this Sep 11, 2024

aj-stein-gsa added a commit that referenced this pull request Sep 17, 2024

Update SSP metadata role constraints (#676) (#686)

b4b1d1b

* Update SSP metadata role constraints * Adjust message text to be more approachable, per PR feedback --------- Co-authored-by: A.J. Stein <aj@gsa.gov>

aj-stein-gsa added a commit that referenced this pull request Sep 24, 2024

Update SSP metadata role constraints (#676) (#686)

b526be0

* Update SSP metadata role constraints * Adjust message text to be more approachable, per PR feedback --------- Co-authored-by: A.J. Stein <aj@gsa.gov>

aj-stein-gsa added a commit that referenced this pull request Sep 25, 2024

Update SSP metadata role constraints (#676) (#686)

e3cd610

* Update SSP metadata role constraints * Adjust message text to be more approachable, per PR feedback --------- Co-authored-by: A.J. Stein <aj@gsa.gov>

This was referenced Nov 13, 2024

develop #900

Closed

chore update container oscal cli js 20241113 #901

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add three SSP metadata role constraints #676

Add three SSP metadata role constraints #676

DimitriZhurkin commented Sep 10, 2024 •

edited by aj-stein-gsa

Loading

aj-stein-gsa Sep 10, 2024

DimitriZhurkin Sep 10, 2024

aj-stein-gsa Sep 10, 2024

DimitriZhurkin Sep 10, 2024

DimitriZhurkin Sep 10, 2024

aj-stein-gsa Sep 10, 2024

wandmagic Sep 11, 2024

aj-stein-gsa left a comment

aj-stein-gsa Sep 11, 2024

DimitriZhurkin Sep 11, 2024 •

edited

Loading

aj-stein-gsa commented Sep 11, 2024

Add three SSP metadata role constraints #676

Add three SSP metadata role constraints #676

Conversation

DimitriZhurkin commented Sep 10, 2024 • edited by aj-stein-gsa Loading

Committer Notes

All Submissions:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aj-stein-gsa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DimitriZhurkin Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

aj-stein-gsa commented Sep 11, 2024

DimitriZhurkin commented Sep 10, 2024 •

edited by aj-stein-gsa

Loading

DimitriZhurkin Sep 11, 2024 •

edited

Loading