Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSP metadata role constraints (#676) #686

Conversation

DimitriZhurkin
Copy link

@DimitriZhurkin DimitriZhurkin commented Sep 11, 2024

Committer Notes

Removed the system-poc-other constraint (#676).

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@aj-stein-gsa aj-stein-gsa force-pushed the feature/update-constraints-#676 branch from 13d5860 to d35e734 Compare September 16, 2024 16:02
aj-stein-gsa
aj-stein-gsa previously approved these changes Sep 16, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for working through the merge conflicts with me.

aj-stein-gsa
aj-stein-gsa previously approved these changes Sep 16, 2024
@aj-stein-gsa
Copy link
Contributor

Since I broke the tests with my rebase and feedback, I will assign myself with @DimitriZhurkin to fix it. 😆

@aj-stein-gsa aj-stein-gsa self-assigned this Sep 16, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed tests once I head a clear mind, focus, and realized roles are in metadata, not inside the controls. And that, children, is a teachable moment in why rebases need to be done with a certain amount of focus. 🚢

@aj-stein-gsa aj-stein-gsa merged commit b4b1d1b into GSA:feature/external-constraints Sep 17, 2024
3 checks passed
aj-stein-gsa added a commit that referenced this pull request Sep 24, 2024
* Update SSP metadata role constraints

* Adjust message text to be more approachable, per PR feedback

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
aj-stein-gsa added a commit that referenced this pull request Sep 25, 2024
* Update SSP metadata role constraints

* Adjust message text to be more approachable, per PR feedback

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
Rene2mt pushed a commit to Rene2mt/fedramp-automation that referenced this pull request Sep 27, 2024
* Update SSP metadata role constraints

* Adjust message text to be more approachable, per PR feedback

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
* Update SSP metadata role constraints

* Adjust message text to be more approachable, per PR feedback

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚢 Ready to Ship
Development

Successfully merging this pull request may close these issues.

2 participants