-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SSP metadata role constraints (#676) #686
Update SSP metadata role constraints (#676) #686
Conversation
fba3bc7
to
13d5860
Compare
13d5860
to
d35e734
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for working through the merge conflicts with me.
Since I broke the tests with my rebase and feedback, I will assign myself with @DimitriZhurkin to fix it. 😆 |
c7d958f
to
076c70f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed tests once I head a clear mind, focus, and realized roles are in metadata, not inside the controls. And that, children, is a teachable moment in why rebases need to be done with a certain amount of focus. 🚢
b4b1d1b
into
GSA:feature/external-constraints
Committer Notes
Removed the system-poc-other constraint (#676).
All Submissions:
If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.