Improve dev constraint script #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-stein-gsa
changed the title
aj-stein-gsa
previously approved these changes
Sep 13, 2024
There was a problem hiding this comment.
This small change looks good and I will test it. Please hold on merging this until #691 is complete given our discussion of the changes. Kudos, Paul. 🫡
wandmagic
force-pushed
the
feature/improve-scaffolding
branch
from
53633fc
to
d67a7d0
Compare
8 tasks
7 tasks
Gabeblis
reviewed
Sep 23, 2024
Gabeblis
reviewed
Sep 23, 2024
aj-stein-gsa
changed the title
|
@wandmagic, I am presuming from chatter in chat about this PR is ready for review? |
aj-stein-gsa
approved these changes
Sep 23, 2024
aj-stein-gsa
merged commit 27e3b23
into
GSA:feature/external-constraints
3 checks passed
aj-stein-gsa
pushed a commit
that referenced
this pull request
Sep 24, 2024
* add option to specify test content be made from template or use all invalid * improve scaffolding for negative test cases * introduce re-run script * update contributing docs for rerun info * improve scaffolding * adjust constraint script to match feedback * Update dev-constraint.js
aj-stein-gsa
pushed a commit
that referenced
this pull request
Sep 25, 2024
* add option to specify test content be made from template or use all invalid * improve scaffolding for negative test cases * introduce re-run script * update contributing docs for rerun info * improve scaffolding * adjust constraint script to match feedback * Update dev-constraint.js
brian-ruf
pushed a commit
to brian-ruf/fedramp-automation
that referenced
this pull request
Nov 8, 2024
* add option to specify test content be made from template or use all invalid * improve scaffolding for negative test cases * introduce re-run script * update contributing docs for rerun info * improve scaffolding * adjust constraint script to match feedback * Update dev-constraint.js
This was referenced Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Ask a new question during test scaffolding:
do you want to use custom content for your unit test, or do you want to use all-INVALID
Follows up on team moving forward on ADR 7 per finalized decision in #700.
All Submissions:
Have you added an explanation of what your changes do and why you'd like us to include them?If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.