Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test data optimization ADR #700

Conversation

Gabeblis
Copy link

Committer Notes

This ADR pertains to the refinement of the method used for employing the test data files 'ssp-all-VALID.xml' and 'ssp-all-INVALID.xml' in the constraint validation tool.

{Please provide a description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please submit the PR as a draft PR using the "Draft pull request" dropdown.}

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis linked an issue Sep 18, 2024 that may be closed by this pull request
8 tasks
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor consideration thus far.

@wandmagic
Copy link
Collaborator

#690
this is ADR is largely implimented here, let me know if we need to make any adjustments to meet the request of this ADR

aj-stein-gsa
aj-stein-gsa previously approved these changes Sep 20, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is still in draft, but I really like the improvements. I was favorable to this change, but now I am even more understanding and supportive after I read this again.

documents/adr/0006-test-data-optimization-ADR.md Outdated Show resolved Hide resolved
@Gabeblis Gabeblis marked this pull request as ready for review September 20, 2024 14:04
@Gabeblis Gabeblis requested a review from a team as a code owner September 20, 2024 14:04
@Gabeblis Gabeblis changed the title Introduce test data optimization ADR Test data optimization ADR Sep 20, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still approve.

Rene2mt
Rene2mt previously approved these changes Sep 20, 2024
aj-stein-gsa
aj-stein-gsa previously approved these changes Sep 20, 2024
documents/adr/0006-test-data-optimization-ADR.md Outdated Show resolved Hide resolved
@aj-stein-gsa aj-stein-gsa dismissed stale reviews from Rene2mt and themself via 958ca31 September 20, 2024 20:34
@aj-stein-gsa aj-stein-gsa merged commit fab2392 into GSA:feature/external-constraints Sep 20, 2024
3 checks passed
@aj-stein-gsa aj-stein-gsa mentioned this pull request Sep 23, 2024
7 tasks
aj-stein-gsa added a commit that referenced this pull request Sep 24, 2024
* Introduce test data optimization ADR

* Correction: only scaffold invalid test data file

* Provide more detail in ADR

* Date correction

* Add solution & consequences

* Add reference to #710.

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
aj-stein-gsa added a commit that referenced this pull request Sep 25, 2024
* Introduce test data optimization ADR

* Correction: only scaffold invalid test data file

* Provide more detail in ADR

* Date correction

* Add solution & consequences

* Add reference to #710.

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
Rene2mt pushed a commit to Rene2mt/fedramp-automation that referenced this pull request Sep 27, 2024
* Introduce test data optimization ADR

* Correction: only scaffold invalid test data file

* Provide more detail in ADR

* Date correction

* Add solution & consequences

* Add reference to GSA#710.

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
* Introduce test data optimization ADR

* Correction: only scaffold invalid test data file

* Provide more detail in ADR

* Date correction

* Add solution & consequences

* Add reference to GSA#710.

---------

Co-authored-by: A.J. Stein <aj@gsa.gov>
@aj-stein-gsa aj-stein-gsa mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor test data for constraints for conflicting test requirements
4 participants