General cleanup related to 'system-characteristics' constraints #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted yaml fail test files where necessary, removed 2 constraints that are handled by the schema
…cted yaml fail test files where necessary, removed 1 constraint that is handled by the schema
aj-stein-gsa
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Thanks for the catch and @Gabeblis and explanation, this is great work. It seems by virtue of this issue, we are approving ADR 7 as well.
aj-stein-gsa
merged commit 1acb9d2
into
GSA:feature/external-constraints
3 checks passed
aj-stein-gsa
added a commit
to Gabeblis/fedramp-automation
that referenced
this pull request
Sep 20, 2024
aj-stein-gsa
added a commit
that referenced
this pull request
Sep 20, 2024
* Introduce test data optimization ADR * Correction: only scaffold invalid test data file * Provide more detail in ADR * Date correction * Add solution & consequences * Add reference to #710. --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
8 tasks
aj-stein-gsa
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Fixed targets, created separate invalid files where necessary, redirected yaml fail test files where necessary, removed 2 constraints that are handled by the schema * Fixed targets, created separate invalid files where necessary, redirected yaml fail test files where necessary, removed 1 constraint that is handled by the schema * cleanup
aj-stein-gsa
added a commit
that referenced
this pull request
Sep 24, 2024
* Introduce test data optimization ADR * Correction: only scaffold invalid test data file * Provide more detail in ADR * Date correction * Add solution & consequences * Add reference to #710. --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
aj-stein-gsa
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Fixed targets, created separate invalid files where necessary, redirected yaml fail test files where necessary, removed 2 constraints that are handled by the schema * Fixed targets, created separate invalid files where necessary, redirected yaml fail test files where necessary, removed 1 constraint that is handled by the schema * cleanup
aj-stein-gsa
added a commit
that referenced
this pull request
Sep 25, 2024
* Introduce test data optimization ADR * Correction: only scaffold invalid test data file * Provide more detail in ADR * Date correction * Add solution & consequences * Add reference to #710. --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
Rene2mt
pushed a commit
to Rene2mt/fedramp-automation
that referenced
this pull request
Sep 27, 2024
) * Fixed targets, created separate invalid files where necessary, redirected yaml fail test files where necessary, removed 2 constraints that are handled by the schema * Fixed targets, created separate invalid files where necessary, redirected yaml fail test files where necessary, removed 1 constraint that is handled by the schema * cleanup
Rene2mt
pushed a commit
to Rene2mt/fedramp-automation
that referenced
this pull request
Sep 27, 2024
* Introduce test data optimization ADR * Correction: only scaffold invalid test data file * Provide more detail in ADR * Date correction * Add solution & consequences * Add reference to GSA#710. --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
brian-ruf
pushed a commit
to brian-ruf/fedramp-automation
that referenced
this pull request
Nov 8, 2024
) * Fixed targets, created separate invalid files where necessary, redirected yaml fail test files where necessary, removed 2 constraints that are handled by the schema * Fixed targets, created separate invalid files where necessary, redirected yaml fail test files where necessary, removed 1 constraint that is handled by the schema * cleanup
brian-ruf
pushed a commit
to brian-ruf/fedramp-automation
that referenced
this pull request
Nov 8, 2024
* Introduce test data optimization ADR * Correction: only scaffold invalid test data file * Provide more detail in ADR * Date correction * Add solution & consequences * Add reference to GSA#710. --------- Co-authored-by: A.J. Stein <aj@gsa.gov>
This was referenced Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Description
Removed system-characteristics constraints that are handled by the schema, and tests for each of these constraints. I also created separate invalid test files for constraints that caused conflicts in the
ssp-all-INVALID.xmlfile. I moved some metapath for constraints from "test" to "target" so that it is cleaner and easier to understand. The metapath was originally in the test because this was a workaround that allowed the constraints to all share the samessp-all-INVALID.xmlfile without conflicts. The functionality is the exact same. These changes should be added as they are part of the effort write all of the constraints from the constraint tracker.Changes
has-authorization-boundary-diagram-uuid,has-network-architecture-description,has-network-architecture-diagram-uuidfromfedramp-external-constraints.xml.system-characteristicsconstraints to be cleaner and easier to understand.All Submissions:
- [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?- [ ] If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.