Feature/all valid test #896
Open
+2,341
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Gabeblis <gabriel.rodriguez@gsa.gov>
Co-Authored-By: Gabeblis <gabriel.rodriguez@gsa.gov>
Co-Authored-By: Gabeblis <gabriel.rodriguez@gsa.gov>
- Update oscal-cli to the latest stable release (2.3.1). - Update oscal-js to the latest stable release (2.0.6).
aj-stein-gsa
requested changes
Nov 14, 2024
aj-stein-gsa
added
devops
type: backlog item
…rsioning Use (GSA#866) * [skip ci] Deprecate ADR2, backport "new" GSA#847 ADR * [skip ci] Context and decision in GSA#847 ADR * [skip ci] Add two options to GSA#847 ADR * [skip ci] Add option 3, finalize GSA#847 ADR * Apply very valid feedback during review from @Rene2mt Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> * [skip ci] Clarify ADR 10 explanation of past work per @Rene2mt review of GSA#866 Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> * [skip ci] Add missing info to ADR 10 per @Rene2mt's GSA#866 review Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov> --------- Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
Co-authored-by: A.J. Stein <aj@gsa.gov>
Co-authored-by: A.J. Stein <aj@gsa.gov>
aj-stein-gsa
previously approved these changes
Nov 14, 2024
aj-stein-gsa
previously approved these changes
Nov 14, 2024
* Add prepared-for constraints * Add check for embedded address assembly in party * cleanup and extra negative test * sort per style guide * Edit message
Gabeblis
requested changes
Nov 14, 2024
Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
Co-Authored-By: Gabeblis <gabriel.rodriguez@gsa.gov>
Co-Authored-By: Gabeblis <gabriel.rodriguez@gsa.gov>
Co-Authored-By: Gabeblis <gabriel.rodriguez@gsa.gov>
Co-authored-by: A.J. Stein <aj@gsa.gov>
Co-authored-by: A.J. Stein <aj@gsa.gov>
Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
Co-Authored-By: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
…/fedramp-automation into feature/all-valid-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Provides an extra test for all valid documents which we can add to. IE fedramp tamples awesome cloud etc...
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.