Release fixes for py3 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickumia-reisys
approved these changes
Aug 25, 2021
| # Application may not be fully available immediately, wait 5 seconds | ||
| sleep 5 | ||
| # Application may not be fully available immediately, wait 15 seconds | ||
| sleep 15 |
There was a problem hiding this comment.
I hope this number doesn't keep growing 😅
|
|
||
| curl --fail --silent ${APP_URL}/api/action/status_show?$(date +%s) > /dev/null | ||
| [ "403" == "$(curl --silent --output /dev/null --write-out %{http_code} ${APP_URL}/dataset?$(date +%s))" ] | ||
| # [ "403" == "$(curl --silent --output /dev/null --write-out %{http_code} ${APP_URL}/dataset?$(date +%s))" ] |
There was a problem hiding this comment.
Why was this commented out?
There was a problem hiding this comment.
This validates that datagov-inventory extension is installed and the site is not available to the public. Since it's currently not installed, we need to ignore this test for now. We should re-implement once GSA/data.gov#3388 is ready to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against develop cloud.gov space, should be ready for release.
Note that some missing dependencies were not caught in the tests, because the test framework already had core ckan dependencies installed.
Related to GSA/data.gov#3374