Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release fixes for py3 #348

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Release fixes for py3 #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8664a8f
Add paste tools
jbrown-xentity Aug 25, 2021
52abaee
Ignore testing in development
jbrown-xentity Aug 25, 2021
9ad8f2b
Wait for tests to pass, wait 15 sec for smoke test
jbrown-xentity Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bin/smoke.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ set -x

# TODO move smoke tests to python

# Application may not be fully available immediately, wait 5 seconds
sleep 5
# Application may not be fully available immediately, wait 15 seconds
sleep 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this number doesn't keep growing 😅


curl --fail --silent ${APP_URL}/api/action/status_show?$(date +%s) > /dev/null
[ "403" == "$(curl --silent --output /dev/null --write-out %{http_code} ${APP_URL}/dataset?$(date +%s))" ]
# [ "403" == "$(curl --silent --output /dev/null --write-out %{http_code} ${APP_URL}/dataset?$(date +%s))" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This validates that datagov-inventory extension is installed and the site is not available to the public. Since it's currently not installed, we need to ignore this test for now. We should re-implement once GSA/data.gov#3388 is ready to be merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. 👍


echo ok
2 changes: 2 additions & 0 deletions requirements.in.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ Jinja2==2.11.3
PyJWT==1.7.1
Markdown==2.6.7
passlib==1.7.3
pastedeploy==2.0.1 # manually kept - remove when #4802 is complete
pathtools==0.1.2 # via watchdog
polib==1.0.7
psycopg2==2.8.2
python-magic==0.4.15
Expand Down
2 changes: 2 additions & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ newrelic==6.8.1.164
nose==1.3.7
packaging==21.0
passlib==1.7.3
pastedeploy==2.0.1 # manually kept - remove when #4802 is complete
pathtools==0.1.2 # via watchdog
pbr==5.6.0
pika==1.2.0
polib==1.0.7
Expand Down