Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix $DIAMOND_PATH uninitialised error with --skipAllTraining option #54

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gemygk
Copy link

@gemygk gemygk commented Jul 19, 2024

Running galba.pl with the --skipAllTraining flag causes the $DIAMOND_PATH variable to be uninitialised, which leads to a failure in the filter_gtf_by_diamond_against_ref.py script.

This PR resolves the issue, and my test run has completed successfully.

Below are the details to replicate the error
Command used:

galba.pl  --skipAllTraining --workingdir=/path/to/output \
    --genome /path/to/genome.fa --prot_seq=/path/to/proteins.fa \
    --gff3 --verbosity=4 --threads 8 --species=genus_species \
    --AUGUSTUS_CONFIG_PATH /path/to/config

Error from STDERR

Use of uninitialized value $DIAMOND_PATH in concatenation (.) or string at /opt/GALBA/scripts/galba.pl line 6186.
ERROR in file /opt/GALBA/scripts/galba.pl at line 6191

Error from errors/filter_gtf_by_diamond_against_ref.stderr

$ cat errors/filter_gtf_by_diamond_against_ref.stderr
usage: filter_gtf_by_diamond_against_ref.py [-h] -r REF_PROTS [-g GTF]
                                            [-a PRED_PROTS] -o OUT_GTF
                                            [-t THREADS] -d DIAMOND_DIR
filter_gtf_by_diamond_against_ref.py: error: argument -d/--diamond_dir: expected one argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant