Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlflow.yml is not parsed properly when using TemplatedConfigLoader #72

Closed
Galileo-Galilei opened this issue Sep 29, 2020 · 0 comments · Fixed by #91
Closed

mlflow.yml is not parsed properly when using TemplatedConfigLoader #72

Galileo-Galilei opened this issue Sep 29, 2020 · 0 comments · Fixed by #91
Labels
bug Something isn't working
Milestone
Release 0.4.0

Comments

@Galileo-Galilei
Copy link
Owner

When you have a global variable in the mlflow.yml file (e.g mlruns: ${USER}/mlruns), the global variable is not replaced by its value even if the user has registered a TemplatedConfigLoader in his project. This is due to get_mlflow_config() to manually recreate the default ConfigLoader.

This is part of the numerous issues that will be fixed by #66.
@Galileo-Galilei Galileo-Galilei self-assigned this Sep 29, 2020
@Galileo-Galilei Galileo-Galilei added the bug Something isn't working label Sep 29, 2020
@Galileo-Galilei Galileo-Galilei added this to the Release 0.4.0 milestone Sep 29, 2020
@Galileo-Galilei Galileo-Galilei mentioned this issue Sep 29, 2020
Closed
3 tasks
@Galileo-Galilei Galileo-Galilei removed their assignment Oct 1, 2020
takikadiri added a commit to takikadiri/kedro-mlflow that referenced this issue Oct 11, 2020
@takikadiri
FIX Galileo-Galilei#66 Galileo-Galilei#64 Galileo-Galilei#54 Galileo-…
d691b96 
…Galilei#30 Galileo-Galilei#31 Galileo-Galilei#72 Galileo-Galilei#29 Galileo-Galilei#62 - context access - kedro 16.5 - hook auto registration
@takikadiri takikadiri mentioned this issue Oct 11, 2020
Closed
6 tasks
@takikadiri takikadiri mentioned this issue Oct 15, 2020
Merged
6 tasks
@takikadiri takikadiri linked a pull request Oct 15, 2020 that will close this issue
FIX #66 - accessing project context #91
Merged
6 tasks
takikadiri added a commit that referenced this issue Oct 17, 2020
@takikadiri
FIX #66 - Accessing project context inside hooks (and consequently fix …
26b6572 
…#30 #64 #72)
Galileo-Galilei pushed a commit that referenced this issue Oct 17, 2020
@takikadiri @Galileo-Galilei
FIX #66 - Accessing project context inside hooks (and consequently fix …
e8f9f09 
…#30 #64 #72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
kedro-mlflow roadmap
Status: ✅ Done
Milestone
Release 0.4.0
Development

Successfully merging a pull request may close this issue.

FIX #66 - accessing project context Galileo-Galilei/kedro-mlflow
1 participant
@Galileo-Galilei