-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #66 - accessing project context #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
79d8bbe
to
26b6572
Compare
Codecov Report
@@ Coverage Diff @@
## develop #91 +/- ##
===========================================
+ Coverage 97.33% 97.45% +0.12%
===========================================
Files 32 32
Lines 1201 1258 +57
===========================================
+ Hits 1169 1226 +57
Misses 32 32
Continue to review full report at Codecov.
|
closes #66 #30 #72
Description
This PR intend to fix mlflow configs related issues.
Development notes
Some important changes :
kedro-mlflow can now access to project context properties. That decouple the plugin from the template.
We used this access to change get_mlflow_config signature, the test have been updated accordignately.
I add a .kedro.yml file, src folder and run.py file to the kedro project fixture for tests running in kedro 0.16.5
For more details, see changes.
Checklist
Checklist
CHANGELOG.md
file. Please respect Keep a Changelog guidelines.Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.