uc-crux-llvm: Specify function postconditions #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langston-barrett
force-pushed
the
lb/postcond
branch
from
9034345
to
cc32688
Compare
|
I think this would probably be quite a bit easier to review if we merge #980 first and then rebase - could we give that a try? |
|
Absolutely! Would you mind giving that one a look then? |
This was referenced May 12, 2022
langston-barrett
force-pushed
the
lb/postcond
branch
from
cc32688
to
4029a92
Compare
The Postcondition module declares a type that approximates a specification of a function's postconditions. This is used in Classify to infer such postconditions on return values, in the future it may be used to infer information about clobbered memory. This module supersedes the "Clobber" specs that were part of the Skip override machinery. These weren't amenable to use-cases such as inference. Also implement some additional pretty-printing machinery.
langston-barrett
force-pushed
the
lb/postcond
branch
from
4029a92
to
c970b60
Compare
|
@travitch Rebased! |
travitch
reviewed
May 16, 2022
Work in progress, tests don't compile. Will remove added Datalayout m types everywhere in next commit.
The instances are TemplateHaskell generated, and need to be in scope for this code.
travitch
reviewed
May 18, 2022
travitch
approved these changes
May 18, 2022
This avoids the need for an unsafeCoerce
Weirdly, GHC 9 doesn't seem to like how these were written. Change to something equivalent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Postconditionmodule declares a type that approximates a specification of a function's postconditions. This is used inClassifyto infer such postconditions on return values, in the future it may be used to infer information about clobbered memory.Also implement some additional pretty-printing machinery.
This is based on top of #980, which it requires. We could merge that first and rebase this, or just merge this.