-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple mistake leads to moral crushing error message #826
Comments
In an ideal world, what would you like to see here? It might be possible to add a hint about using the wrong arrow to the |
Have you used Clang? It has this really cool "Did you mean?" thing it does with errors. Following their error handling, In an ideal world I would l see: [Error] something on line something something The arrow is bolded...GitHub needs colors! |
@robdockins...I know you've used Clang. |
We already have some code to prioritize type errors, so maybe we should add a case where kind errors disable all other type errors, I think it is reasonable to make people fix the kind errors before we show them other stuff. As for the "did you mean part", I think to get that to work, we'd have to remember the context in which the kind error occurred, (e.g., checking a user signature), which we currently don't, but shouldn't be hard to do. |
You know what would be really cool? If the "did you mean" part works, after the kind errors, the rest of the checking could be predicated on assuming that you did actually mean those things. I imagine you would get much more relevant error messages. |
We were thinking of having Cryptol show only kind error messages when there is a kind error, and not show a bunch of type error messages in that case. |
Should be fixed by MR #908 |
So, we're teaching a class on Cryptol. One of the students writes the following:
Which produces this when read into Cryptol:
I'm pretty sure this is the error message that most closely relates to the actual bug:
But even that doesn't tell the student what he did wrong.
The text was updated successfully, but these errors were encountered: