Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typechecker error message improvements #908

Merged
merged 8 commits into from
Sep 25, 2020
Merged

Typechecker error message improvements #908

merged 8 commits into from
Sep 25, 2020

Conversation

yav
Copy link
Member

@yav yav commented Sep 23, 2020

This addresses issues #746 and #826

Copy link
Contributor

@brianhuffman brianhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. My only question is, do the regression tests demonstrate all the possible new error messages? It looks like the issue382 test covers quite a few. If there are any missing, then we should add more tests; otherwise I think it's good.

@yav
Copy link
Member Author

yav commented Sep 24, 2020

Good point, we didn't have these before but I just added some tests which demonstrate all the errors I could make happen. There were a few that don't seem to fire so I made a ticket to look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants