Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build/package cryptol binary for saw 0.8 release #1184

Closed
lisanna-dettwyler opened this issue Apr 12, 2021 · 0 comments
Closed

Don't build/package cryptol binary for saw 0.8 release #1184

lisanna-dettwyler opened this issue Apr 12, 2021 · 0 comments
Assignees
Labels
tooling: build system Issues involving SAW's build system
Milestone

Comments

@lisanna-dettwyler
Copy link
Contributor

It's not used by saw and it's not typically even a released version of cryptol, and including a binary of it in the distribution can imply that it's gone through the same build/release process as a real cryptol release, when it hasn't.

@lisanna-dettwyler lisanna-dettwyler added this to the 0.8 milestone Apr 12, 2021
@lisanna-dettwyler lisanna-dettwyler added the tooling: build system Issues involving SAW's build system label Apr 12, 2021
@lisanna-dettwyler lisanna-dettwyler self-assigned this Apr 12, 2021
lisanna-dettwyler pushed a commit that referenced this issue Apr 19, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184
lisanna-dettwyler pushed a commit that referenced this issue Apr 19, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184
lisanna-dettwyler pushed a commit that referenced this issue Apr 19, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184
lisanna-dettwyler pushed a commit that referenced this issue Apr 19, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184
lisanna-dettwyler pushed a commit that referenced this issue Apr 19, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184
lisanna-dettwyler pushed a commit that referenced this issue Apr 19, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184
lisanna-dettwyler pushed a commit that referenced this issue Apr 19, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184
lisanna-dettwyler pushed a commit that referenced this issue Apr 19, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184
lisanna-dettwyler pushed a commit that referenced this issue Apr 19, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184
lisanna-dettwyler pushed a commit that referenced this issue Apr 19, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184
lisanna-dettwyler pushed a commit that referenced this issue Apr 20, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184

- Clean version numbers for release

Closes #982
lisanna-dettwyler pushed a commit that referenced this issue Apr 20, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184

- Clean version numbers for release

Closes #982
lisanna-dettwyler pushed a commit that referenced this issue Apr 20, 2021
Closes #1171

- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1184

- Cryptol binaries are no longer included in release tarballs

Closes #982

- Clean version numbers for release
pnwamk pushed a commit that referenced this issue Apr 21, 2021
Closes #1171

- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1184

- Cryptol binaries are no longer included in release tarballs

Closes #982

- Clean version numbers for release
@pnwamk pnwamk closed this as completed in 1bf96a3 Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling: build system Issues involving SAW's build system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant