Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release builds have cleaner version numbers #982

Closed
atomb opened this issue Dec 17, 2020 · 0 comments
Closed

Make release builds have cleaner version numbers #982

atomb opened this issue Dec 17, 2020 · 0 comments
Assignees
Milestone

Comments

@atomb
Copy link
Contributor

atomb commented Dec 17, 2020

The released versions of 0.6 and 0.7 have banners like the following:

 ┏━━━┓━━━┓━┓━┓━┓
 ┃ ━━┓ ╻ ┃ ┃ ┃ ┃
 ┣━━ ┃ ╻ ┃┓ ╻ ┏┛
 ┗━━━┛━┛━┛┗━┛━┛ version 0.7 (670e349-dirty)



sawscript>

This includes the commit hash and the string dirty indicating that it's not just a clean checkout of the repository. We should fix this before releasing 0.8.

@atomb atomb added this to the 0.8 milestone Dec 17, 2020
@atomb atomb self-assigned this Jan 15, 2021
lisanna-dettwyler pushed a commit that referenced this issue Apr 19, 2021
CI will no longer cause the git tree to become dirty prior to build

Closes #982
lisanna-dettwyler pushed a commit that referenced this issue Apr 20, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184

- Clean version numbers for release

Closes #982
lisanna-dettwyler pushed a commit that referenced this issue Apr 20, 2021
- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1171

- Cryptol binaries are no longer included in release tarballs

Closes #1184

- Clean version numbers for release

Closes #982
lisanna-dettwyler pushed a commit that referenced this issue Apr 20, 2021
Closes #1171

- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1184

- Cryptol binaries are no longer included in release tarballs

Closes #982

- Clean version numbers for release
pnwamk pushed a commit that referenced this issue Apr 21, 2021
Closes #1171

- Publish docker images -> ghcr.io
- Deduplicate / normalize build and publish logic
- Make sure release branches are getting verified correctly

Closes #1184

- Cryptol binaries are no longer included in release tarballs

Closes #982

- Clean version numbers for release
@pnwamk pnwamk closed this as completed in 1bf96a3 Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants