Proof summary improvements #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdockins
force-pushed
the
proof-summary
branch
from
f992bda
to
5db07a7
Compare
robdockins
force-pushed
the
proof-summary
branch
2 times, most recently
from
d078994
to
0e496b0
Compare
atomb
approved these changes
May 28, 2021
| @@ -154,7 +154,7 @@ makeSimpset params = do | |||
| v <- getServerVal n | |||
| case v of | |||
| VSimpset ss' -> return (merge ss ss') | |||
| VTerm t -> return (addSimp (ttTerm t) ss) | |||
| VTerm t -> return (addSimp (ttTerm t) Nothing ss) -- TODO! making rewrite rules from terms! | |||
There was a problem hiding this comment.
Maybe we should just remove this case. I don't think it'll break any existing proofs, and we can add convenience functions for proving and then making simpsets from terms in the Python client.
including source positions.
This allows users to add metadata their rewrite rules, and have rewriting steps record and return the metadata for rules what were actually used in rewriting. The intention is to use these annotations to link rewrite rules back to theorems/axioms that generated them so proof steps can determine the dependencies of a proof.
Currently, we use trivial `()` annotations and ignore annotations collected by rewrite steps. The plan is to allocate unique nonces for each theorem and use those to track theorem dependencies.
TODO! We currently are allowing users to create simpsets from raw terms, and probably we should only let `Theorem` values be turned into rewrite rules.
Instead, users should use `core_axiom` or `prove_print (admit "...")` to turn terms into theorems for use with `addsimp` or `addsimps`.
Add a unique value to each generated theorem, and compute the set of theorems a proof depends on while checking evidence. Track the collection of all proved theorems during a run in a `TheoremDB`; later we should be able to generate a graph of theorem depencencies from this database.
specs that have been proved or assumed.
These are now output in JSON verification summaries.
We parse a verification summary JSON file and produce a Graphviz file intended to be fed into `dot` to produce a visulaization. For large proofs, especially, the layout is problematic; however, even so, it seems like a helpful way to scroll through a proof and get a sense of what is proved and what depends on what.
displaying verification conditions of method specs. This reduces clutter in the graph and produces more readable output.
in saw-remote-api
robdockins
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some initial steps toward improving proof summaries. This currently involves tracking additional metadata about the origin of theorems and preliminary steps toward tracking dependencies between proofs.