-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run s2n tests for only one GHC version #1386
Conversation
fe85be6
to
888a45d
Compare
I don't know how easy/hard this is to do, but it would be nice if the s2n tests only depended on the particular build that they need in order to run. As it is now, they wait for all builds to successfully complete before beginning. In particular, if one of the builds fails because of some configuration situation, the proof tests don't run at all. For example, the Windows 8.8.4 build currently seems like it might stall until it is canceled, and the proof tests will never run, preventing merging. |
I entirely agree with that, but I unfortunately also don't know how hard it is to do. At the very least, it'll require learning some more about how GitHub Actions work. |
@@ -167,7 +162,7 @@ jobs: | |||
path: dist/bin | |||
name: ${{ runner.os }}-bins | |||
|
|||
- if: "matrix.os == 'ubuntu-18.04'" | |||
- if: "matrix.os == 'ubuntu-20.04'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to make this if: runner.os == 'Linux'
so that it's immunized against future ubuntu release updates?
The concern here is that the matrix entries might be updated without checking the rest of the file for matches and suddenly this step silently stops being run.
e7eab47
to
6db1287
Compare
Older Z3 and Ubuntu versions are causing trouble.
6db1287
to
4d1c15d
Compare
At this point, this PR is actually all about updating GHC and Z3 versions, which may not actually be something we want to do right now. |
The important parts of this have been incorporated into other PRs, and the remainder has been re-done in better ways. |
This may not fix the timeout issues we're seeing, but at least it'll reduce the amount of work we're doing, and reduce the number of tests that might timeout.
Also fixes several other CI issues discovered along the way.