Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize memory invalidation in postcondition use. #593

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Optimize memory invalidation in postcondition use. #593

merged 1 commit into from
Dec 6, 2019

Conversation

andreistefanescu
Copy link
Contributor

A memory allocation that is overwritten by a postcondition memory
write not invalidated anymore.

@andreistefanescu
Optimize memory invalidation in postcondition use.
604a612 
A memory allocation that is overwritten by a postcondition memory
write not invalidated anymore.
atomb
atomb approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. Have you observed that this gives better performance in practice, or is it precautionary?

@andreistefanescu
Copy link
Contributor Author

@atomb I noticed a performance regression in the BIKE/SIKE proofs. This fixes it.

@brianhuffman brianhuffman merged commit 52b14b5 into master Dec 6, 2019
chameco added a commit to chameco/saw-script that referenced this pull request Dec 7, 2019
@chameco
Revert "Merge pull request GaloisInc#593 from GaloisInc/invalidate-me…
1c7873c 
…mory-optimization"

This reverts commit 52b14b5, reversing
changes made to 39b9bc4.
@chameco chameco mentioned this pull request Dec 7, 2019
Closed
andreistefanescu added a commit that referenced this pull request Dec 8, 2019
@andreistefanescu
Fix resolveSetupVal error introduced in #593.
aaf91c8
andreistefanescu added a commit that referenced this pull request Dec 9, 2019
@andreistefanescu
Fix resolveSetupVal error introduced in #593.
9f0ccf0
andreistefanescu added a commit that referenced this pull request Dec 9, 2019
@andreistefanescu
Fix resolveSetupVal error introduced in #593. (#609)
56c0472
@andreistefanescu andreistefanescu deleted the invalidate-memory-optimization branch December 20, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomb atomb atomb approved these changes

@brianhuffman brianhuffman Awaiting requested review from brianhuffman

@robdockins robdockins Awaiting requested review from robdockins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreistefanescu @atomb @brianhuffman