Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolveSetupVal error introduced in #593. #609

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Fix resolveSetupVal error introduced in #593. #609

merged 1 commit into from
Dec 9, 2019

Conversation

andreistefanescu
Copy link
Contributor

In invalidateMutableAllocs, resolveSetupValue fails if any of the pointers in the postcondition are not resolved. In order to resolve those pointers, now executeAllocation runs before invalidateMutableAllocs.

@andreistefanescu
Copy link
Contributor Author

cc @chameco

brianhuffman
brianhuffman approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@brianhuffman brianhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andreistefanescu andreistefanescu merged commit 56c0472 into master Dec 9, 2019
@andreistefanescu andreistefanescu deleted the fix-593 branch December 9, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhuffman brianhuffman brianhuffman approved these changes

@atomb atomb Awaiting requested review from atomb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreistefanescu @brianhuffman