Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch Templates #2

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Launch Templates #2

merged 3 commits into from
Jun 14, 2022

Conversation

GavinBurris42
Copy link
Owner

…hese methods into flow on creating a spot instance

Issue #, if available:

Description of changes: Created functions for creating and deleting Launch Templates. Added mocks and tests for creating and deleting Launch Templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinBurris42 GavinBurris42 requested a review from snay2 June 14, 2022 15:20
pkg/ec2helper/ec2helper.go Outdated Show resolved Hide resolved
pkg/ec2helper/ec2helper.go Outdated Show resolved Hide resolved
pkg/ec2helper/ec2helper.go Outdated Show resolved Hide resolved
pkg/ec2helper/ec2helper.go Outdated Show resolved Hide resolved
pkg/ec2helper/ec2helper.go Outdated Show resolved Hide resolved
cmd/launch.go Outdated Show resolved Hide resolved
…ixed issues with Launch Template tests as well
Copy link
Collaborator

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not yet convinced that the existing mock implementation of DescribeLaunchTemplatesPages is incorrect or that it wouldn't work for this usecase. But we can proceed as-is while I research that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants