-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for launching Spot instances #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capacity Question
…hese methods into flow on creating a spot instance
…ixed issues with Launch Template tests as well
Launch Templates
… to use an existing mock method.
Refactored tests for creating and deleting launch templates
CreateFleet to create spot instance
…tances to be connectable. Also fixed bug so launch templates can create spot instances.
…S configuration, tags, auto-termination, and other configurations
snay2
suggested changes
Jul 25, 2022
snay2
suggested changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting one more change since we discovered a bug in the error handling.
Co-authored-by: Steve Nay <265958+snay2@users.noreply.github.com>
Co-authored-by: Steve Nay <265958+snay2@users.noreply.github.com>
snay2
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #55
Description of changes: Added capacity type question to the end of Simple-EC2 questionnaire. Allows for the user to choose between Spot or On-Demand when creating an instance. Uses Launch Templates and the CreateFleet API to launch spot instances based on user configuration settings. Pricing for Spot and On-Demand is provided from the Instance-Selector tool to inform the user of realtime instance pricing.
Reviews for each smaller piece of this feature were conducted on a fork:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.