Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for launching Spot instances #85

Merged
merged 31 commits into from
Jul 29, 2022

Conversation

GavinBurris42
Copy link
Contributor

@GavinBurris42 GavinBurris42 commented Jul 22, 2022

Issue #, if available: #55

Description of changes: Added capacity type question to the end of Simple-EC2 questionnaire. Allows for the user to choose between Spot or On-Demand when creating an instance. Uses Launch Templates and the CreateFleet API to launch spot instances based on user configuration settings. Pricing for Spot and On-Demand is provided from the Instance-Selector tool to inform the user of realtime instance pricing.

Reviews for each smaller piece of this feature were conducted on a fork:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Burris and others added 28 commits June 1, 2022 14:44
…hese methods into flow on creating a spot instance
…ixed issues with Launch Template tests as well
Refactored tests for creating and deleting launch templates
CreateFleet to create spot instance
…tances to be connectable. Also fixed bug so launch templates can create spot instances.
…S configuration, tags, auto-termination, and other configurations
@GavinBurris42 GavinBurris42 requested a review from snay2 July 22, 2022 20:04
@GavinBurris42 GavinBurris42 requested a review from a team as a code owner July 22, 2022 20:04
@snay2 snay2 changed the title Move to prod Add support for launching Spot instances Jul 22, 2022
pkg/question/question.go Outdated Show resolved Hide resolved
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting one more change since we discovered a bug in the error handling.

pkg/ec2helper/ec2helper.go Show resolved Hide resolved
GavinBurris42 and others added 2 commits July 29, 2022 12:44
Co-authored-by: Steve Nay <265958+snay2@users.noreply.github.com>
Co-authored-by: Steve Nay <265958+snay2@users.noreply.github.com>
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants