Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of spot instances #5

Merged
merged 6 commits into from
Jun 20, 2022
Merged

Configuration of spot instances #5

merged 6 commits into from
Jun 20, 2022

Conversation

GavinBurris42
Copy link
Owner

Issue #, if available:

Description of changes: Configured spot instances to match the configuration of On-Demand instances. Spot instances now can be connected to.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinBurris42 GavinBurris42 requested a review from snay2 June 17, 2022 18:33
Copy link
Collaborator

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR description with the testing steps you used to verify this, since we don't have integration tests for spot support yet?

cmd/launch.go Outdated Show resolved Hide resolved
pkg/ec2helper/ec2helper.go Outdated Show resolved Hide resolved
pkg/ec2helper/ec2helper.go Outdated Show resolved Hide resolved
pkg/ec2helper/ec2helper.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants