Refactored question defaults #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults if available
cjerad
suggested changes
Jun 24, 2022
added 2 commits
June 27, 2022 14:11
…ges to questions relating to user defaults in simple-ec2
cjerad
suggested changes
Jun 28, 2022
snay2
requested changes
Jun 28, 2022
…g, and other issues
cjerad
suggested changes
Jun 29, 2022
snay2
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Confirmed with Gavin offline that the unit tests are passing, even though this PR didn't run them automatically.
The existing unit tests now verify that the original code paths still function the same when user defaults are not supplied. I would also like to see some new tests to positively verify that user defaults are chosen instead when passed in.
But the new tests can be in a separate PR. This one looks good to me now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ults if available
Issue #, if available: awslabs#75
Description of changes: Refactored question defaults to set saved user configurations as defaults if available
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.